fix: configure Undertow test entity size#12892
Open
Zhengcy05 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12859
Background
This PR updates the grpc-servlet Undertow tests to work with Undertow
2.2.39.Finaland2.3.21.Final.Those releases changed Undertow's default
MAX_ENTITY_SIZEto 2 MiB, which causedUndertowInteropTest.veryLargeRequest()to fail before the request reached the gRPC servlet.Cause
UndertowInteropTest.veryLargeRequest()sends a 10 MiB unary request. The test server already configured gRPC'smaxInboundMessageSize, but it did not configure Undertow's container-level entity size limit.After the Undertow default changed, the container started rejecting the request and the client saw
RST_STREAM ... CANCEL.Changes
UndertowOptions.MAX_ENTITY_SIZEexplicitly inUndertowInteropTestUndertowOptions.MAX_ENTITY_SIZEexplicitly inUndertowTransportTestto keep the transport test environment effectively unbounded2.2.39.Finaland2.3.21.FinalVerification
./gradlew -PskipAndroid=true -PskipCodegen=true :grpc-servlet:undertowTest --tests io.grpc.servlet.UndertowInteropTest./gradlew -PskipAndroid=true -PskipCodegen=true :grpc-servlet:undertowTest --tests io.grpc.servlet.UndertowTransportTest