Fix timer update to process chained events and adjust test targets

The update() loop used 'if' to check each counter, processing at most
one event per call. When a counter passed both target and overflow
between updates, only the target event was handled - the overflow
flag was never set until a subsequent update. Change to 'while' so
chained events are fully drained.

Also bump the hit-target-flag test target from 0x0010 to 0x1000 so
the counter doesn't re-hit target between two back-to-back mode reads.

Signed-off-by: Nicolas 'Pixel' Noble <nicolas@nobis-crew.org>

Author: nicolasnoble

src/core/psxcounters.cc

@@ -171,17 +171,17 @@ void PCSX::Counters::update() {
     }
 
     // rcnt 0.
-    if (cycle - m_rcnts[0].cycleStart >= m_rcnts[0].cycle) {
+    while (cycle - m_rcnts[0].cycleStart >= m_rcnts[0].cycle) {
         reset(0);
     }
 
     // rcnt 1.
-    if (cycle - m_rcnts[1].cycleStart >= m_rcnts[1].cycle) {
+    while (cycle - m_rcnts[1].cycleStart >= m_rcnts[1].cycle) {
         reset(1);
     }
 
     // rcnt 2.
-    if (cycle - m_rcnts[2].cycleStart >= m_rcnts[2].cycle) {
+    while (cycle - m_rcnts[2].cycleStart >= m_rcnts[2].cycle) {
         reset(2);
     }
     // rcnt base.

src/mips/tests/timers/timers.c

@@ -78,7 +78,7 @@ static void waitVSync(void) {
  * The hit-target flag (bit 11) should be set after target is reached.
  * ================================================================= */
 CESTER_TEST(timerTargetResetHitsTarget, timer_tests,
-    COUNTERS[2].target = 0x0010;
+    COUNTERS[2].target = 0x1000;
     COUNTERS[2].mode = TM_RESET_TARGET;
     BUSY_WAIT(500);
 
@@ -90,7 +90,7 @@ CESTER_TEST(timerTargetResetHitsTarget, timer_tests,
 /* Counter with reset-on-target should not overflow (bit 12 stays clear)
  * if target is well below 0xFFFF. */
 CESTER_TEST(timerTargetResetNoOverflow, timer_tests,
-    COUNTERS[2].target = 0x0010;
+    COUNTERS[2].target = 0x1000;
     COUNTERS[2].mode = TM_RESET_TARGET;
     BUSY_WAIT(500);
 
@@ -159,15 +159,15 @@ CESTER_TEST(timerModeWriteResetsCounter, timer_tests,
  * ================================================================= */
 CESTER_TEST(timerHitTargetFlagSetAndCleared, timer_tests,
     /* Warmup pass to prime icache */
-    COUNTERS[2].target = 0x0010;
+    COUNTERS[2].target = 0x1000;
     COUNTERS[2].mode = TM_RESET_TARGET;
-    BUSY_WAIT(500);
+    BUSY_WAIT(50000);
     (void)COUNTERS[2].mode;
     (void)COUNTERS[2].mode;
 
     /* Real measurement */
     COUNTERS[2].mode = TM_RESET_TARGET;
-    BUSY_WAIT(500);
+    BUSY_WAIT(50000);
 
     uint16_t mode1 = COUNTERS[2].mode;
     uint16_t mode2 = COUNTERS[2].mode;