[GUI] Cleaning up more GL code.

Author: wheremyfoodat

src/gui/gui.cc

@@ -466,6 +466,8 @@ end)(jit.status()))
     m_biosEditor.title = []() { return _("BIOS"); };
     m_biosEditor.show = false;
 
+    m_offscreenShaderEditor.init();
+    m_outputShaderEditor.init();
     m_offscreenShaderEditor.compile(this);
     m_outputShaderEditor.compile(this);
 
@@ -647,6 +649,7 @@ void PCSX::GUI::flip() {
 }
 
 void PCSX::GUI::endFrame() {
+    constexpr float renderRatio = 3.0f / 4.0f;
     auto& io = ImGui::GetIO();
     // bind back the output frame buffer
     glBindFramebuffer(GL_FRAMEBUFFER, 0);
@@ -656,7 +659,7 @@ void PCSX::GUI::endFrame() {
     int w, h;
     glfwGetFramebufferSize(m_window, &w, &h);
     m_renderSize = ImVec2(w, h);
-    normalizeDimensions(m_renderSize, m_renderRatio);
+    normalizeDimensions(m_renderSize, renderRatio);
 
     bool changed = false;
 
@@ -689,7 +692,7 @@ void PCSX::GUI::endFrame() {
                 _("Output"), &outputShown,
                 ImGuiWindowFlags_NoScrollbar | ImGuiWindowFlags_NoScrollWithMouse | ImGuiWindowFlags_NoCollapse)) {
             ImVec2 textureSize = ImGui::GetContentRegionAvail();
-            normalizeDimensions(textureSize, m_renderRatio);
+            normalizeDimensions(textureSize, renderRatio);
             ImTextureID texture = reinterpret_cast<ImTextureID*>(m_offscreenTextures[m_currentTexture]);
             m_outputShaderEditor.renderWithImgui(this, texture, m_renderSize, textureSize);
         }

src/gui/gui.h

@@ -200,7 +200,6 @@ class GUI final {
     ImVec4 m_backgroundColor = ImColor(114, 144, 154);
     ImVec2 m_renderSize = ImVec2(1, 1);
 
-    float m_renderRatio = 3.0f / 4.0f;
     bool &m_fullscreen = {settings.get<Fullscreen>().value};
 
     // GUI

src/gui/widgets/shader-editor.cc

@@ -162,6 +162,11 @@ void PCSX::Widgets::ShaderEditor::setDefaults() {
     m_luaEditor.setText(c_defaultLuaInvoker);
 }
 
+void PCSX::Widgets::ShaderEditor::init() {
+    glGenVertexArrays(1, &m_vao);
+    glGenBuffers(1, &m_vbo);
+}
+
 std::optional<GLuint> PCSX::Widgets::ShaderEditor::compile(GUI *gui,
                                                            const std::vector<std::string_view> &mandatoryAttributes) {
     GLint status = 0;
@@ -698,13 +703,7 @@ void PCSX::Widgets::ShaderEditor::render(GUI *gui, GLuint textureID, const ImVec
         return;
     }
 
-    if (m_vao == 0) {
-        glGenVertexArrays(1, &m_vao);
-        glGenBuffers(1, &m_vbo);
-    }
-
     glBindVertexArray(m_vao);
-
     glUseProgram(m_shaderProgram);
     struct VertexData {
         float positions[3];

src/gui/widgets/shader-editor.h

@@ -52,6 +52,7 @@ class ShaderEditor {
     }
 
     void setDefaults();
+    void init();
     void reset(GUI*);
 
     bool draw(GUI*, const char* title);