Quotes for flags, add flag propogation to lua and paths

[johnbaumann]

No description provided.

[coderabbitai]

Walkthrough

This set of changes updates the Makefile rules for building static libraries in the psyqo-lua, psyqo-paths, and psyqo components. The modifications ensure that the CPPFLAGS and LDFLAGS variables, specific to the current build configuration, are explicitly passed to recursive make invocations. In the case of psyqo.mk, these variables are now wrapped in double quotes to handle values with spaces or special characters correctly. No changes to exported or public entities are introduced.

Changes

File(s)	Change Summary
src/mips/psyqo-lua/psyqo-lua.mk	Modified to pass CPPFLAGS_$(BUILD) and LDFLAGS_$(BUILD) to recursive make for build configuration.
src/mips/psyqo-paths/psyqo-paths.mk	Updated to forward CPPFLAGS_$(BUILD) and LDFLAGS_$(BUILD) to sub-make for current build config.
src/mips/psyqo/psyqo.mk	Changed to wrap CPPFLAGS_$(BUILD) and LDFLAGS_$(BUILD) in quotes when passing to sub-make.

Possibly related PRs

• Cascade build options for psyqo projects. #1854: Also modifies psyqo.mk to pass CPPFLAGS_$(BUILD) and LDFLAGS_$(BUILD) to recursive make, closely related to this PR's refinement with quoted variables.

Poem

In the warren where Makefiles hop,
Flags now travel to the top,
Wrapped in quotes, they safely go,
Through recursive burrows low.
Each library builds with care anew—
A bunny’s work, precise and true!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e0a17f and 118d4e6.

📒 Files selected for processing (3)

• src/mips/psyqo-lua/psyqo-lua.mk (1 hunks)
• src/mips/psyqo-paths/psyqo-paths.mk (1 hunks)
• src/mips/psyqo/psyqo.mk (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (11)

• GitHub Check: pcsx-redux (x86_64-linux)
• GitHub Check: pcsx-redux (aarch64-linux)
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: coverage
• GitHub Check: build
• GitHub Check: toolchain
• GitHub Check: macos-build-and-test-toolchain
• GitHub Check: build-openbios
• GitHub Check: asan
• GitHub Check: aur-build
• GitHub Check: cross-arm64

🔇 Additional comments (3)

src/mips/psyqo-lua/psyqo-lua.mk (1)

17-17: Added flag propagation for recursive make.

The change ensures that compiler preprocessor flags (CPPFLAGS) and linker flags (LDFLAGS) specific to the current build configuration are properly passed to the recursive make invocation. This is important for maintaining consistent build settings across all components of the project.

The double quotes around $(CPPFLAGS_$(BUILD)) and $(LDFLAGS_$(BUILD)) are essential to preserve any spaces or special characters in these variables when they're passed to the sub-make process.

src/mips/psyqo-paths/psyqo-paths.mk (1)

9-9: Added flag propagation for recursive make.

Similar to the change in psyqo-lua.mk, this modification ensures that build-specific compiler and linker flags are correctly passed to the recursive make process. The double quotes around the flag variables prevent shell word splitting issues that could occur with flag values containing spaces or special characters.

src/mips/psyqo/psyqo.mk (1)

11-11: Added quotes around flag variables.

This change properly wraps the CPPFLAGS_$(BUILD) and LDFLAGS_$(BUILD) values in double quotes, ensuring that any spaces or special characters in these flags are preserved when passed to the sub-make process. This is important for flags that might contain complex values like -D"MACRO=\"String with spaces\"".

This completes the standardization of flag handling across all the related makefiles in the project.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)

• src/mips/psyqo-lua/psyqo-lua.mk: Language not supported
• src/mips/psyqo-paths/psyqo-paths.mk: Language not supported
• src/mips/psyqo/psyqo.mk: Language not supported