Fix GDB packet p (readRegister)

[yaz0r]

dumpOneRegister(n) doesn't actually send the result back, so need to add a write for the result. Tested against an homebrew GDB client.

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The handling of the "p" command in the PCSX::GdbClient::processCommand() method was updated to ensure that the result of reading a single register is now sent back to the GDB client. No other logic or public interfaces were changed.

Changes

Cohort / File(s)	Change Summary
GDB Command Response Update src/core/gdb-server.cc	Modified the "p" command handling to send the register value response back to the GDB client.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A register’s value, once kept inside,
Now travels the wire with digital pride.
The GDB client waits, ears all a-twitch—
At last, the reply! No more a glitch.
A hop, a skip, a bug takes flight—
All’s well in the debugger’s night.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2a6d77 and b4e77de.

📒 Files selected for processing (1)

• src/core/gdb-server.cc (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: macos-intel-build-and-test
• GitHub Check: pcsx-redux (x86_64-linux)
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: toolchain
• GitHub Check: aur-build

🔇 Additional comments (1)

src/core/gdb-server.cc (1)

523-523: LGTM! Essential fix for GDB "p" command.

The change correctly sends the register value back to the GDB client. Without this write() call, the dumpOneRegister(n) result was computed but never transmitted, causing the GDB client to hang waiting for a response.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR fixes a bug in the GDB server's register reading functionality where the p (readRegister) command was not sending results back to the client.

• Fixes the p command to actually send register data back to the GDB client
• Wraps the dumpOneRegister(n) call with write() to ensure the result is transmitted

[Copilot]

The change assumes dumpOneRegister(n) returns a value that can be passed to write(), but without seeing the function signature, this could cause a compilation error if dumpOneRegister() returns void or an incompatible type.

Suggested change

	write(dumpOneRegister(n));
	write(std::string(dumpOneRegister(n)));