Updating fmt to 12.1.0

[nicolasnoble]

No description provided.

[coderabbitai]

Walkthrough

The third_party/fmt submodule reference is updated to a newer commit, advancing the dependency without introducing directly visible code changes within this repository's source tree.

Changes

Cohort / File(s)	Summary
Submodule Update third_party/fmt	Submodule reference updated from commit e69e5f977d458f2650bb346dadf2ad30c5320281 to 407c905e45ad75fc29bf0f9bb7c5c2fd3475976f

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Submodule pointer updates are straightforward administrative changes with no local code logic to review

Possibly related PRs

• Fix build with fmt 11 #1871: Addresses fmt-11 API changes (const qualifier on fmt::formatter::format) that this submodule update may incorporate.

Poem

🐰 A library leaps to a newer revision,
Dependencies dance in a fresh composition!
fmt marches forward with vigor and grace,
Bringing improvements to this codebase.
Hop, hop, hooray! 📚✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to evaluate whether any description is related to the changeset.	Add a brief description explaining the reason for the fmt upgrade (e.g., bug fixes, new features, security updates) and any testing performed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: updating the fmt library dependency to version 12.1.0, which matches the submodule reference update shown in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd9959a and ae8c5cb.

📒 Files selected for processing (1)

• third_party/fmt (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: pcsx-redux (x86_64-linux)
• GitHub Check: pcsx-redux (aarch64-linux)
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: aur-build
• GitHub Check: build
• GitHub Check: coverage
• GitHub Check: toolchain
• GitHub Check: asan
• GitHub Check: cross-arm64

🔇 Additional comments (1)

third_party/fmt (1)

1-1: Now let me search the codebase for fmt usage patterns to assess compatibility:

Let me search the codebase for fmt usage:

Based on comprehensive verification through web searches and analysis of fmt 12.1.0 release notes, I can now provide the final review comment:

---

fmt 12.1.0 submodule update is safe to proceed.

The target commit (407c905) corresponds to fmt 12.1.0 and includes buffer optimization and an approximately 16% improvement on spdlog benchmarks. The release contains no breaking API changes—changes include buffer optimizations, ABI incompatibility workarounds between clang and gcc, and C++ module compatibility fixes. No security vulnerabilities have been identified in fmt 12.1.0.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}