Add lua event listener for CPU::Interrupt and scheduleInterrupt #1996
CodeScene PR Check
Quality Gate Failed
Gates Failed
(2 files with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| eventslua.cc | 1 advisory rule | 9.58 → 9.55 | Suppress |
| r3000a.cc | 1 advisory rule | 6.79 → 6.78 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method eventslua.cc: PCSX::LuaBindings::open_events
- Complex Method r3000a.cc: PCSX::R3000Acpu::branchTest
✅ Improving Code Health:
- Overall Code Complexity luawrapper.cc
Annotations
Check warning on line 211 in src/core/eventslua.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
PCSX::LuaBindings::open_events increases in cyclomatic complexity from 15 to 16, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 399 in src/core/r3000a.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
PCSX::R3000Acpu::branchTest already has high cyclomatic complexity, and now it increases in Lines of Code from 70 to 71. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in src/lua/luawrapper.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.75 to 4.65, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.