Fix CI workflow triggering: replace deprecated cancel-previous-runs with native concurrency groups#2002
Merged
nicolasnoble merged 1 commit intomainfrom Apr 14, 2026
Conversation
…ncy groups; add workflow_dispatch to test workflows; update checkout actions to v4 Agent-Logs-Url: https://github.com/grumpycoders/pcsx-redux/sessions/5796c515-8274-4fb0-8fc4-4e0ca6a3ac07 Co-authored-by: nicolasnoble <7281574+nicolasnoble@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
nicolasnoble
April 14, 2026 05:23
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
==========================================
+ Coverage 9.11% 9.63% +0.51%
==========================================
Files 470 506 +36
Lines 147911 149164 +1253
==========================================
+ Hits 13482 14370 +888
- Misses 134429 134794 +365 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause Analysis: Why PR #2001's Tests Didn't Start
PR #2001 ("Fix timer accuracy") has 6 commits on the
fix-timer-accuracybranch. Linux CI ran successfully for 5 of them, including several that failed tests (Timers.InterpreterandTimers.Dynarec). The latest commit1a963643a9(an amended/force-pushed commit froma6398599) never triggered the GitHub Actions workflows, even though the Azure DevOps Windows builds did trigger correctly.The root cause is a GitHub transient webhook delivery failure: the
pull_requestsynchronizeevent was not delivered for this specific force push. This was compounded by the use ofn1hility/cancel-previous-runs@v2, which runs on deprecated Node.js 20 (flagged with deprecation warnings in CI logs), making it a reliability risk going forward.Changes
To properly enable triggering CI for this and future similar situations:
n1hility/cancel-previous-runs@v2with native GitHubconcurrency:groups across all 10 CI workflow files. This is the modern built-in equivalent (no third-party action, no Node.js dependency) and is more reliable.workflow_dispatch:trigger tolinux-build.ymlandlinux-asan.yml— the two primary test workflows — so maintainers can manually re-trigger them from the Actions UI when GitHub misses a webhook event.actions/checkout@v1/v2/v3→v4across all workflows to eliminate Node.js 20 deprecation warnings.How to Re-trigger PR #2001's Tests
Once this PR is merged to
main, a maintainer can use the "Run workflow" button in the Linux CI and Linux CI asan Actions pages to manually dispatch a run. Alternatively, the PR author can push a trivial commit to re-trigger CI automatically.