Add ram viewer. #2003
Add ram viewer. #2003
CodeScene PR Check
Quality Gate Failed
Gates Failed
New code is healthy
(1 new file with code health below 9.00)
Enforce critical code health rules
(1 file with Bumpy Road Ahead, Deep, Nested Complexity)
Enforce advisory code health rules
(4 files with Complex Method, Complex Conditional, Large Method, Overall Code Complexity)
Gates Passed
1 Quality Gates Passed
See analysis details in CodeScene
Reason for failure
| New code is healthy | Violations | Code Health Impact | |
|---|---|---|---|
| ram-viewer.cc | 6 rules | 5.90 | Suppress |
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| ram-viewer.cc | 2 critical rules | 5.90 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| ram-viewer.cc | 4 advisory rules | 5.90 | Suppress |
| ramlogger.cc | 1 advisory rule | 9.69 | Suppress |
| zoomable-image.cc | 1 advisory rule | 9.69 | Suppress |
| debug.cc | 1 advisory rule | 4.06 → 4.01 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional ram-viewer.cc: main
- Complex Method debug.cc: PCSX::Debug::process
- Bumpy Road Ahead ram-viewer.cc: PCSX::Widgets::RAMViewer::draw
- Overall Code Complexity ram-viewer.cc
- Large Method ram-viewer.cc: PCSX::Widgets::RAMViewer::imguiCB
- Complex Method ram-viewer.cc: main
- Complex Method ram-viewer.cc: PCSX::Widgets::RAMViewer::draw
- Complex Conditional ramlogger.cc: PCSX::RAMLogger::enable
- Deep, Nested Complexity ram-viewer.cc: PCSX::Widgets::RAMViewer::imguiCB
- Deep, Nested Complexity ram-viewer.cc: PCSX::Widgets::RAMViewer::draw
- Complex Conditional zoomable-image.cc: PCSX::Widgets::ZoomableImage::handlePanZoom
- Complex Method ram-viewer.cc: PCSX::Widgets::RAMViewer::drawRAM
- Bumpy Road Ahead ram-viewer.cc: main
Annotations
Check warning on line 241 in src/core/debug.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
PCSX::Debug::process increases in cyclomatic complexity from 88 to 100, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 58 in src/core/ramlogger.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
PCSX::RAMLogger::enable has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 197 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
main has a cyclomatic complexity of 28, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 565 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
PCSX::Widgets::RAMViewer::draw has a cyclomatic complexity of 26, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 460 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
PCSX::Widgets::RAMViewer::drawRAM has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 185 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
main has 4 complex conditionals with 12 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 402 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Large Method
PCSX::Widgets::RAMViewer::imguiCB has 87 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 565 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
PCSX::Widgets::RAMViewer::draw has 9 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 197 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
main has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 1 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Overall Code Complexity
This module has a mean cyclomatic complexity of 7.08 across 12 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check warning on line 402 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
PCSX::Widgets::RAMViewer::imguiCB has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check warning on line 565 in src/gui/widgets/ram-viewer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
PCSX::Widgets::RAMViewer::draw has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check warning on line 50 in src/gui/widgets/zoomable-image.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Conditional
PCSX::Widgets::ZoomableImage::handlePanZoom has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.