Retargetting project for vs2026.#2005
Merged
nicolasnoble merged 2 commits intogrumpycoders:mainfrom Apr 17, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis pull request updates the C/C++ compiler toolset across 39 Visual Studio project files from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
vsprojects/freetype/freetype.vcxproj (1)
980-1000: Consider centralizing MSVC toolset selection in shared props.This value is duplicated across many projects/configurations; defining it once in
vsprojects/common.props(and only overridingClangCLwhere needed) would reduce future retarget churn.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@vsprojects/freetype/freetype.vcxproj` around lines 980 - 1000, The PlatformToolset value is duplicated across configurations; move the default PlatformToolset declaration into vsprojects/common.props (e.g., set <PlatformToolset>v145</PlatformToolset> as the shared default) and remove the repeated <PlatformToolset> entries from project PropertyGroup blocks (including Release|x64 and ReleaseWithTracy|x64), leaving only explicit overrides where necessary (keep the ClangCl override in the ReleaseWithClangCL|x64 PropertyGroup). Ensure projects read the shared property by importing common.props so only configurations requiring ClangCl explicitly set <PlatformToolset>ClangCl</PlatformToolset>.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@vsprojects/freetype/freetype.vcxproj`:
- Around line 980-1000: The PlatformToolset value is duplicated across
configurations; move the default PlatformToolset declaration into
vsprojects/common.props (e.g., set <PlatformToolset>v145</PlatformToolset> as
the shared default) and remove the repeated <PlatformToolset> entries from
project PropertyGroup blocks (including Release|x64 and ReleaseWithTracy|x64),
leaving only explicit overrides where necessary (keep the ClangCl override in
the ReleaseWithClangCL|x64 PropertyGroup). Ensure projects read the shared
property by importing common.props so only configurations requiring ClangCl
explicitly set <PlatformToolset>ClangCl</PlatformToolset>.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a6c7d202-9e4a-4f04-8705-226cd3ca4a65
📒 Files selected for processing (42)
vsprojects/ImFileDialog/ImFileDialog.vcxprojvsprojects/Lua/Lua.vcxprojvsprojects/SPU/SPU.vcxprojvsprojects/authoring/authoring.vcxprojvsprojects/capstone/capstone_static.vcxprojvsprojects/cdrom/cdrom.vcxprojvsprojects/clip/clip.vcxprojvsprojects/common.propsvsprojects/core/core.vcxprojvsprojects/exe2elf/exe2elf.vcxprojvsprojects/exe2iso/exe2iso.vcxprojvsprojects/fmt/fmt.vcxprojvsprojects/freetype/freetype.vcxprojvsprojects/gtest/gtest.vcxprojvsprojects/gui/gui.vcxprojvsprojects/imgui-glfw-ogl3/imgui-glfw-ogl3.vcxprojvsprojects/imgui_lua_bindings/imgui_lua_bindings.vcxprojvsprojects/imgui_md/imgui_md.vcxprojvsprojects/libcurl/libcurl.vcxprojvsprojects/libuv/libuv.vcxprojvsprojects/llhttp/llhttp.vcxprojvsprojects/lpeg/lpeg.vcxprojvsprojects/luv/luv.vcxprojvsprojects/main/main.vcxprojvsprojects/mainthunk/mainthunk.vcxprojvsprojects/md4c/md4c.vcxprojvsprojects/modconv/modconv.vcxprojvsprojects/multipart-parser/multipart-parser.vcxprojvsprojects/nanovg/nanovg.vcxprojvsprojects/pcsx-wrapper/pcsx-wrapper.vcxprojvsprojects/ps1-packer/ps1-packer.vcxprojvsprojects/psyq-obj-parser/psyq-obj-parser.vcxprojvsprojects/soft/soft.vcxprojvsprojects/support/support.vcxprojvsprojects/supportpsx/supportpsx.vcxprojvsprojects/tests/memoryleakdetector/memoryleakdetector.vcxprojvsprojects/tests/pcsxrunner/pcsxrunner.vcxprojvsprojects/tests/support/testsupport.vcxprojvsprojects/tracy/tracy.vcxprojvsprojects/uriparser/uriparser.vcxprojvsprojects/zep/zep.vcxprojvsprojects/zlib/zlib.vcxproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.