psyqo: add selectable framebuffer Layout - #2051
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 file with Code Duplication)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| gpu.cpp | 1 advisory rule | 7.48 → 6.73 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication gpu.cpp
✅ Improving Code Health:
- Complex Method gpu.cpp: psyqo::GPU::flip
- Bumpy Road Ahead gpu.cpp: psyqo::GPU::flip
Annotations
Check warning on line 306 in src/mips/psyqo/src/gpu.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Code Duplication
The module contains 7 functions with similar structure: psyqo::GPU::getClear,psyqo::GPU::getNextClear,psyqo::GPU::getNextScissor,psyqo::GPU::getScissor
and 3 more functions
Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check notice on line 243 in src/mips/psyqo/src/gpu.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ Getting better: Complex Method
psyqo::GPU::flip decreases in cyclomatic complexity from 14 to 13, threshold = 9
This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid
adding more conditionals and code to it without refactoring.
Check notice on line 243 in src/mips/psyqo/src/gpu.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Bumpy Road Ahead
psyqo::GPU::flip is no longer above the threshold for logical blocks with deeply nested code
The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The
deeper the nesting and the more bumps, the lower the code health.