Skip to content

Increase bios_size to 1MB#630

Open
ABelliqueux wants to merge 9 commits into
grumpycoders:mainfrom
ABelliqueux:main
Open

Increase bios_size to 1MB#630
ABelliqueux wants to merge 9 commits into
grumpycoders:mainfrom
ABelliqueux:main

Conversation

@ABelliqueux

Copy link
Copy Markdown
Contributor

:p

@wheremyfoodat

wheremyfoodat commented Oct 4, 2021

Copy link
Copy Markdown
Collaborator

@ABelliqueux
Uhhh you'd need to adjust the memory handlers, recompiler etc to work with 1MB BIOSes too. And you'd also want to detect a 1MB BIOS before treating a BIOS as such.

@nicolasnoble

Copy link
Copy Markdown
Member

There are lots of other places this would need to be updated unfortunately :)

(this doesn't pass basic tests because of a buffer overflow).

@codecov

codecov Bot commented Oct 31, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.76%. Comparing base (1d81a0a) to head (af21852).
⚠️ Report is 4449 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #630   +/-   ##
=======================================
  Coverage   25.76%   25.76%           
=======================================
  Files         189      189           
  Lines       56225    56225           
=======================================
  Hits        14484    14484           
  Misses      41741    41741           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants