🐛 (eks sync-core-components): Increase maxEKSBuild, do binary search#216
🐛 (eks sync-core-components): Increase maxEKSBuild, do binary search#216thisguycodes wants to merge 1 commit into
Conversation
|
I feel this is a more permanent solution than #215, and it makes performance more consistent across the board. But I acknowledge it's much more complex so I'll leave it to the maintainers to decide. |
|
Hi @thisguycodes , we are testing this PR now. Can you confirm what version of |
|
I'm using the latest release, v0.13.0 |
|
Hi @thisguycodes, we got #215 merged and released. v0.13.1 addresses the issue (I just verified). Thanks again for the contribution! We can keep this PR open if you would like. I plan to circle back to function to update to a more robust solution that is less constrained with the limits and the overall implementation. |
|
Happy to keep it open! |
There are in fact 10 builds of eks/coredns:1.9.3-eksbuild. This jumps the threshold from 10 to 128, and switches to doing a binary search rather than a forward crawl to keep the request count down.
9caad3a to
0309e3b
Compare
Description
Fixes #214
Replaces #215
The maximum number of builds (sub-patches?) to search for with eks compnent images was hard coded to 10 (actually 9, since the last one has to error / miss for the code to work), but there are in fact 10 builds of eks/coredns:1.9.3-eksbuild. This massively jumps the threshold to 128, and switches to doing a binary search rather than a forward crawl to keep the request count down.
At present any attempt to create / update an EKS cluster using version 1.24 through 1.26 will error (see #214).
feature/new-vpc-endpoints-955orbug/missing-count-param-434.- [ ] Update the docs.- [ ] Run the relevant tests successfully.Release Notes
Find eksbuild's via binary search, Fixes #214