Skip to content

Navigation Menu

Appearance settings

- AI CODE CREATION
  GitHub CopilotWrite better code with AI
  GitHub Copilot appDirect agents from issue to merge
  MCP Registry^NewIntegrate external tools
- DEVELOPER WORKFLOWS
  ActionsAutomate any workflow
  CodespacesInstant dev environments
  IssuesPlan and track work
  Code ReviewManage code changes
- APPLICATION SECURITY
  GitHub Advanced SecurityFind and fix vulnerabilities
  Code securitySecure your code as you build
  Secret protectionStop leaks before they start
- EXPLORE
  Why GitHub
  Documentation
  Blog
  Changelog
  Marketplace
View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

grunweg / mathlib4 Public

forked from leanprover-community/mathlib4

Notifications You must be signed in to change notification settings
Fork 0
Star 0

Code
Pull requests 1
Actions
Projects
Security and quality
Insights

Additional navigation options

Code
Pull requests
Actions
Projects
Security and quality
Insights

review: suggested changes for #27021#1

Merged

grunweg merged 47 commits into

grunweg:diffgeo-custom-elaboratorsgrunweg/mathlib4:diffgeo-custom-elaboratorsfrom

thorimur:diffgeo-custom-elaborators-reviewthorimur/mathlib4:diffgeo-custom-elaborators-reviewCopy head branch name to clipboard

Oct 6, 2025

Conversation Commits47 (47)Checks Files changed

Merged

review: suggested changes for #27021#1
grunweg merged 47 commits into
grunweg:diffgeo-custom-elaboratorsfrom
thorimur:diffgeo-custom-elaborators-review

Commits

Commits on Oct 4, 2025

(Git wrangling) Revert "Fix test; tweak error message"
thorimur
committed
(Git wrangling) Revert "Fix"
thorimur
committed
(Git wrangling) Revert "chore: move getUniverse to Lean/Meta/ElabTerm"
thorimur
committed
(Git wrangling) Revert "chore: move mkApp12 to a Lean"
thorimur
committed
style: remove `>>=`
thorimur
committed

Commits on Oct 6, 2025

chore: reduce `etype` to get `.forallE`
thorimur
committed
chore: `whnfR` after `instantiateMVars`
thorimur
committed
chore: remove `getUniverse` in favor of `mkAppOptM`
thorimur
committed
chore: `PrettyPrinter.delab` -> `Term.exprToSyntax`
thorimur
committed
chore(Elaborators): change trace class names
thorimur
committed
feat: move trace classes into main file; make collective trace class; make descriptions into docstrings
thorimur
committed
chore: rename `find_model` -> `findModel`, `_find_models` -> `findModels`
thorimur
committed
chore: use Qq to construct `WithTop ℕ∞`
thorimur
committed
refactor: factor out loops into (private) definitions for readability; search local instances for classes instead of whole context
thorimur
committed
chore: remove unnecessary `m!`s
thorimur
committed
style: use `withLocalDeclD`
thorimur
committed
chore: append `Elab` namespace
thorimur
committed
style: fix `findModel` body indentation
thorimur
committed
chore: grammar
thorimur
committed
style: code fencing instead of quotes in messages
thorimur
committed
chore: typo
thorimur
committed
fix: don't use `BEq` to compare expressions
thorimur
committed
fix: do not use `arg` precedence in brackets
thorimur
committed
fix: reset `TermElabM` state in `findModel` appropriately when trying different strategies; refactor `findModel` to make this possible.
thorimur
committed
chore: use `match_expr` in `findModel`
thorimur
committed
chore: use `match_expr` in `T%`
thorimur
committed
chore: remove `mkApp12`
thorimur
committed
style: use dot notation for `hasLooseBVars`
thorimur
committed
chore: move `findSomeLocalInstanceOf?` above `T%`
thorimur
committed
chore: comment for `findSomeLocalInstanceOf?`
thorimur
committed
chore: use `findSomeLocalInstanceOf?` in `T%`, and explain why we don't use `match_expr`
thorimur
committed
chore: perform cheapest check first
thorimur
committed
chore: use `pureIsDefEq` or explain why not
thorimur
committed
chore: comment out (fixed) `MDiffAt2` and remove test
thorimur
committed
chore: use commented-out code instead of syntax re-elab
thorimur
committed
chore: TODO comments
thorimur
committed
fix: make elaborators `scoped`, as promised
thorimur
committed
docs: clean up module docstring
thorimur
committed
docs: misc. style, typos, wording
thorimur
committed
style(`T%`): `e.app`
thorimur
committed
style: line reflow
thorimur
committed
fix: scope `T%` to `Manifold`
thorimur
committed
chore: refactor `findModels` to clean up elabs
thorimur
committed
style: indent second line of multiline errors
thorimur
committed
chore: improve error message for trivial bundle
thorimur
committed
test: tracing
thorimur
committed
chore: affirm that this check is fine!
thorimur
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.