Fix undefined array key warnings breaking JSON response in getAllHeaders#24
Merged
Merged
Conversation
$params['mediaType'] and $params['lang'] are optional query parameters that may not be present in every request. In PHP 8, accessing a missing array key emits a Warning that, with display_errors enabled, gets prepended to the JSON response body and makes it unparseable by the JavaScript test runner. Fixed by using null-coalescing operators so absent params default to null rather than triggering a warning.
Contributor
|
@philarcher +1 #24 #25 and #26 all looking nice and would "unblock" some of our testcases as well |
There was a problem hiding this comment.
Pull request overview
This PR fixes PHP 8 “undefined array key” warnings in the getAllHeaders test handler that can corrupt JSON API responses (when display_errors is enabled) by ensuring optional query parameters default to null when absent.
Changes:
- Use null-coalescing for optional
$params['mediaType']and$params['lang']when callinggetCustomHeaders(...). - Prevent warnings from being emitted into the JSON response body for requests that omit these parameters.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$params['mediaType'] and $params['lang'] are optional query parameters that may not be present in every request. In PHP 8, accessing a missing array key emits a Warning that, with display_errors enabled, gets prepended to the JSON response body and makes it unparseable by the JavaScript test runner.
Fixed by using null-coalescing operators so absent params default to null rather than triggering a warning.