Forward linkType and context query params to resolver URL in getAllHeaders#25
Open
rmedic wants to merge 2 commits into
Open
Forward linkType and context query params to resolver URL in getAllHeaders#25rmedic wants to merge 2 commits into
rmedic wants to merge 2 commits into
Conversation
…aders The JS test runner sends linkType, context, mediaType and lang as separate query parameters to tester.php (e.g. ?test=getAllHeaders&testVal=... &linkType=gs1:pip&lang=de). Previously, linkType and context were parsed but silently discarded, so the cURL request to the resolver was made against the bare URL without ?linkType=... This caused the resolver to redirect to its default link rather than the requested link type, producing false failures for all per-link-type redirect tests. Fixed by appending linkType and context as query parameters to the resolver URI before the cURL call. mediaType and lang correctly remain as Accept and Accept-Language HTTP headers.
Contributor
|
+1 - please accept and deploy |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR ensures linkType and context query parameters provided to tester.php for the getAllHeaders test are forwarded to the resolver URL used by getCustomHeaders, preventing incorrect redirects and false failures in per-link-type redirect tests.
Changes:
- Build a resolver URI by appending
linkTypeandcontextas query parameters before issuing the cURL request. - Keep
mediaTypeandlangmapped toAcceptandAccept-Languagerequest headers (now passed as optional values).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…d query strings Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JS test runner sends linkType, context, mediaType and lang as separate query parameters to tester.php (e.g. ?test=getAllHeaders&testVal=... &linkType=gs1:pip&lang=de). Previously, linkType and context were parsed but silently discarded, so the cURL request to the resolver was made against the bare URL without ?linkType=... This caused the resolver to redirect to its default link rather than the requested link type, producing false failures for all per-link-type redirect tests.
Fixed by appending linkType and context as query parameters to the resolver URI before the cURL call. mediaType and lang correctly remain as Accept and Accept-Language HTTP headers.