Handle URL-encoded linkType in Location header and unexpected 300 responses#26
Open
rmedic wants to merge 1 commit into
Open
Handle URL-encoded linkType in Location header and unexpected 300 responses#26rmedic wants to merge 1 commit into
rmedic wants to merge 1 commit into
Conversation
…ponses Two fixes in testMultipleLinks: 1. The stripping logic for linkType in the redirect Location header only checked for the unencoded form (e.g. gs1:pip). When a resolver echoes the linkType back URL-encoded (gs1%3Apip), the check failed and the parameter was not stripped before comparison. Now checks both encoded and unencoded forms. 2. When a resolver returns 300 Multiple Choices for a link type that the test expected to redirect (not in threehundredLinks), the test silently failed with no explanation. Now surfaces this as a warn with a message indicating the resolver returned 300 and verification was not possible.
Member
|
Thanks @rmedic for this and the other PRs. I'll dedicate some time to this as soon as I can but please be patient. It won't be before the end of the month due to other commitments and travel. |
Contributor
|
@philarcher pinging back here as well ;-) Would be cool to get these MRs accepted and deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in testMultipleLinks:
The stripping logic for linkType in the redirect Location header only checked for the unencoded form (e.g. gs1:pip). When a resolver echoes the linkType back URL-encoded (gs1%3Apip), the check failed and the parameter was not stripped before comparison. Now checks both encoded and unencoded forms.
When a resolver returns 300 Multiple Choices for a link type that the test expected to redirect (not in threehundredLinks), the test silently failed with no explanation. Now surfaces this as a warn with a message indicating the resolver returned 300 and verification was not possible.