strip linkType from both sides of the redirect compare; fix push(m) typo#27
Open
sboeckelmann wants to merge 1 commit into
Open
Conversation
Resolvers whose linkset href carries `?linkType=...` (valid URI; convenient for self-served links) were failing testSingleLinkObject / testMultipleLinks because the strip ran on the Location header only — never on targetURL — so identical URLs compared unequal once one side had been shortened. Also the identical-attributes loop pushed `m` in both branches, leaving `f` (typically index 0) out of the 300-candidate set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolvers whose linkset href carries
?linkType=...(valid URI; convenient for self-served links) were failing testSingleLinkObject / testMultipleLinks because the strip ran on the Location header only — never on targetURL — so identical URLs compared unequal once one side had been shortened.Also the identical-attributes loop pushed
min both branches, leavingf(typically index 0) out of the 300-candidate set.