#23 - Send valid CORS preflight request to check Access-Control-Request-Method header#31
Open
louisaxel-ambroise wants to merge 1 commit into
Conversation
…quest-Method header Fixes the 1st issue raised in gs1#23 The Access-Control-Request-Method header must only be returned in the preflight (HTTP verb OPTIONS) request. This change adds a new test value/method in the tester.php file and updates the methodsCheck test in JSON to send a valid preflight request and check the existance of the header values from its response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 1st issue raised in #23
The Access-Control-Request-Method header must only be returned in the preflight (HTTP verb OPTIONS) request.
This change adds a new test value/method in the tester.php file and updates the methodsCheck test in JSON to send a valid preflight request and check the existance of the header values from its response.