Revert @vitest/eslint-plugin 1.6.21 bump#252
Conversation
1.6.21's "Chai-style expect chains" change (upstream #920) regressed vitest/valid-expect to flag `expect.any(...)` as an unknown modifier (upstream #924), which fails `--max-warnings=0` lint on the pre-existing `expect.any(String)` assertion in vitest-config's test. #241 surfaced this on main only once turbo cache invalidation forced the lint to re-run against the bumped plugin. Revert the catalog to the last-good 1.6.20 and add a repo-local Renovate rule to skip 1.6.21, so Renovate advances straight to the fixed 1.6.22 (#925) once it clears the 3-day minimumReleaseAge quarantine instead of re-applying the broken release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🔇 Additional comments (2)
📝 WalkthroughWalkthroughThe ChangesVitest ESLint Plugin Versioning
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
mainwent red at the Build (lint:eslint) step after #241 bumped@vitest/eslint-plugin1.6.20 → 1.6.21. That release's "Chai-style expect chains" change (upstream #920) regressedvitest/valid-expectto flagexpect.any(...)as an "unknown modifier" (upstream #924), so the pre-existingexpect.any(String)assertion inpackages/vitest-config/test/configure.test.tsfails--max-warnings=0.It surfaced on
main(not on #241's own PR) because #248's source merge invalidated turbo's task cache, forcingvitest-config#lint:eslintto actually re-run against 1.6.21 rather than replay a pre-1.6.21 cache entry.Fix
expect.anyis a valid matcher — so no test change.minimumReleaseAgequarantine, instead of re-applying the broken release. The rule is scoped to.github/renovate.json(not the shared preset) and documents the removal condition.Root-only change (catalog + lockfile + renovate config), so no changeset is required (same as #241).
🤖 Generated with Claude Code