Skip to content

Revert @vitest/eslint-plugin 1.6.21 bump#252

Merged
gtbuchanan merged 1 commit into
mainfrom
fix/vitest-valid-expect
Jul 11, 2026
Merged

Revert @vitest/eslint-plugin 1.6.21 bump#252
gtbuchanan merged 1 commit into
mainfrom
fix/vitest-valid-expect

Conversation

@gtbuchanan

Copy link
Copy Markdown
Owner

Problem

main went red at the Build (lint:eslint) step after #241 bumped @vitest/eslint-plugin 1.6.20 → 1.6.21. That release's "Chai-style expect chains" change (upstream #920) regressed vitest/valid-expect to flag expect.any(...) as an "unknown modifier" (upstream #924), so the pre-existing expect.any(String) assertion in packages/vitest-config/test/configure.test.ts fails --max-warnings=0.

It surfaced on main (not on #241's own PR) because #248's source merge invalidated turbo's task cache, forcing vitest-config#lint:eslint to actually re-run against 1.6.21 rather than replay a pre-1.6.21 cache entry.

Fix

  • Revert the catalog to the last-good 1.6.20 (mature; lint passes). The test code is correct — expect.any is a valid matcher — so no test change.
  • Add a repo-local Renovate rule to skip 1.6.21, so Renovate advances straight to the fixed 1.6.22 (#925) once it clears the 3-day minimumReleaseAge quarantine, instead of re-applying the broken release. The rule is scoped to .github/renovate.json (not the shared preset) and documents the removal condition.

Root-only change (catalog + lockfile + renovate config), so no changeset is required (same as #241).

🤖 Generated with Claude Code

1.6.21's "Chai-style expect chains" change (upstream #920) regressed
vitest/valid-expect to flag `expect.any(...)` as an unknown modifier
(upstream #924), which fails `--max-warnings=0` lint on the pre-existing
`expect.any(String)` assertion in vitest-config's test. #241 surfaced
this on main only once turbo cache invalidation forced the lint to
re-run against the bumped plugin.

Revert the catalog to the last-good 1.6.20 and add a repo-local Renovate
rule to skip 1.6.21, so Renovate advances straight to the fixed 1.6.22
(#925) once it clears the 3-day minimumReleaseAge quarantine instead of
re-applying the broken release.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e61f1eac-ead6-41b6-8a71-3bbf4aca99bd

📥 Commits

Reviewing files that changed from the base of the PR and between d0b1e26 and 8b425f4.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .github/renovate.json
  • pnpm-workspace.yaml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • gtbuchanan/tooling (manual)
📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: CodeRabbit
  • GitHub Check: CI / Build
🔇 Additional comments (2)
pnpm-workspace.yaml (1)

20-20: LGTM!

.github/renovate.json (1)

5-13: LGTM!


📝 Walkthrough

Walkthrough

The @vitest/eslint-plugin catalog version is downgraded to 1.6.20, and Renovate is configured to exclude 1.6.21 with documentation describing the upstream issue.

Changes

Vitest ESLint Plugin Versioning

Layer / File(s) Summary
Catalog pin and Renovate exclusion
.github/renovate.json, pnpm-workspace.yaml
The PNPM catalog uses version 1.6.20, while Renovate excludes version 1.6.21 and documents the reason.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Suggested labels: dependencies

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the revert of the @vitest/eslint-plugin 1.6.21 update.
Description check ✅ Passed The description directly explains the revert and Renovate skip rule for @vitest/eslint-plugin 1.6.21.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gtbuchanan gtbuchanan enabled auto-merge (squash) July 11, 2026 19:26
@gtbuchanan gtbuchanan disabled auto-merge July 11, 2026 19:29
@gtbuchanan gtbuchanan merged commit 426eda9 into main Jul 11, 2026
10 of 11 checks passed
@gtbuchanan gtbuchanan deleted the fix/vitest-valid-expect branch July 11, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant