Merge pull request #110 from ruromero/TC-4723

feat(api): add unknown severity field and enum value

Author: ruromero

api/v5/openapi.yaml

@@ -448,6 +448,9 @@ components:
         low:
           type: integer
           default: 0
+        unknown:
+          type: integer
+          default: 0
         remediations:
           type: integer
           default: 0
@@ -491,6 +494,7 @@ components:
         - HIGH
         - MEDIUM
         - LOW
+        - UNKNOWN
     Issue:
       type: object
       properties:

src/main/java/io/github/guacsec/trustifyda/api/v5/SeverityUtils.java

@@ -27,7 +27,10 @@ public static Severity fromValue(String value) {
   }
 
   // From: https://nvd.nist.gov/vuln-metrics/cvss
-  public static Severity fromScore(float score) {
+  public static Severity fromScore(Float score) {
+    if (score == null) {
+      return Severity.UNKNOWN;
+    }
     if (score < 4) {
       return Severity.LOW;
     }

src/test/java/io/github/guacsec/trustifyda/api/v5/SeverityUtilsTest.java

@@ -37,19 +37,30 @@ void fromValueIsCaseInsensitive() {
   }
 
   @Test
-  void fromValueRejectsUnknownSeverity() {
-    assertThrows(IllegalArgumentException.class, () -> SeverityUtils.fromValue("unknown"));
+  void fromValueParsesUnknownSeverity() {
+    assertEquals(Severity.UNKNOWN, SeverityUtils.fromValue("unknown"));
+    assertEquals(Severity.UNKNOWN, SeverityUtils.fromValue("UNKNOWN"));
+  }
+
+  @Test
+  void fromValueRejectsInvalidSeverity() {
+    assertThrows(IllegalArgumentException.class, () -> SeverityUtils.fromValue("invalid"));
+  }
+
+  @Test
+  void fromScoreReturnsUnknownForNullInput() {
+    assertEquals(Severity.UNKNOWN, SeverityUtils.fromScore(null));
   }
 
   @Test
   void fromScoreMapsCvssRanges() {
-    assertEquals(Severity.LOW, SeverityUtils.fromScore(0));
+    assertEquals(Severity.LOW, SeverityUtils.fromScore(0f));
     assertEquals(Severity.LOW, SeverityUtils.fromScore(3.9f));
-    assertEquals(Severity.MEDIUM, SeverityUtils.fromScore(4));
+    assertEquals(Severity.MEDIUM, SeverityUtils.fromScore(4f));
     assertEquals(Severity.MEDIUM, SeverityUtils.fromScore(6.9f));
-    assertEquals(Severity.HIGH, SeverityUtils.fromScore(7));
+    assertEquals(Severity.HIGH, SeverityUtils.fromScore(7f));
     assertEquals(Severity.HIGH, SeverityUtils.fromScore(8.9f));
-    assertEquals(Severity.CRITICAL, SeverityUtils.fromScore(9));
-    assertEquals(Severity.CRITICAL, SeverityUtils.fromScore(10));
+    assertEquals(Severity.CRITICAL, SeverityUtils.fromScore(9f));
+    assertEquals(Severity.CRITICAL, SeverityUtils.fromScore(10f));
   }
 }