fix: use generic line separator (#169)

## Description

Use a generic line separator regEx for Yarn and Go

**Related issue (if any):** fixes #168 

## Checklist

- [x] I have followed this repository's contributing guidelines.
- [x] I will adhere to the project's code of conduct.

Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>

Author: ruromero

src/main/java/com/redhat/exhort/providers/GoModulesProvider.java

@@ -138,7 +138,7 @@ Sbom getDependenciesSbom(Path manifestPath, boolean buildTree) throws IOExceptio
     boolean matchManifestVersions =
         Environment.getBoolean(Provider.PROP_MATCH_MANIFEST_VERSIONS, false);
     if (matchManifestVersions) {
-      String[] goModGraphLines = goModulesResult.split(System.lineSeparator());
+      String[] goModGraphLines = goModulesResult.split(Operations.GENERIC_LINE_SEPARATOR);
       performManifestVersionsCheck(goModGraphLines, manifestPath);
     }
     if (!buildTree) {
@@ -152,7 +152,7 @@ Sbom getDependenciesSbom(Path manifestPath, boolean buildTree) throws IOExceptio
   private void performManifestVersionsCheck(String[] goModGraphLines, Path manifestPath) {
     try {
       String goModLines = Files.readString(manifestPath);
-      String[] lines = goModLines.split(System.lineSeparator());
+      String[] lines = goModLines.split(Operations.GENERIC_LINE_SEPARATOR);
       String root = getParentVertex(goModGraphLines[0]);
       List<String> comparisonLines =
           Arrays.stream(goModGraphLines)
@@ -271,7 +271,8 @@ private Sbom buildSbomFromGraph(
     // iterate over go mod graph line by line and create map , with each entry to contain module as
     // a key , and
     // value of list of that module' dependencies.
-    List<String> linesList = Arrays.asList(goModulesResult.split(System.lineSeparator()));
+    List<String> linesList =
+        Arrays.asList(goModulesResult.split(Operations.GENERIC_LINE_SEPARATOR));
 
     int startingIndex = 0;
     for (String line : linesList) {
@@ -325,7 +326,7 @@ private Map<String, List<String>> getFinalPackagesVersionsForModule(
     String finalVersionsForAllModules =
         Operations.runProcessGetOutput(manifestPath.getParent(), "go", "list", "-m", "all");
     Map<String, String> finalModulesVersions =
-        Arrays.stream(finalVersionsForAllModules.split(System.lineSeparator()))
+        Arrays.stream(finalVersionsForAllModules.split(Operations.GENERIC_LINE_SEPARATOR))
             .filter(string -> string.trim().split(" ").length == 2)
             .collect(
                 Collectors.toMap(
@@ -437,7 +438,7 @@ private String buildGoModulesDependencies(Path manifestPath) {
   }
 
   private Sbom buildSbomFromList(String golangDeps, List<PackageURL> ignoredDeps) {
-    String[] allModulesFlat = golangDeps.split(System.lineSeparator());
+    String[] allModulesFlat = golangDeps.split(Operations.GENERIC_LINE_SEPARATOR);
     String parentVertex = getParentVertex(allModulesFlat[0]);
     PackageURL root = toPurl(parentVertex, "@", this.goEnvironmentVariableForPurl);
     // Get only direct dependencies of root package/module, and that's it.

src/main/java/com/redhat/exhort/providers/YarnBerryProcessor.java

@@ -20,6 +20,7 @@
 import com.github.packageurl.PackageURL;
 import com.redhat.exhort.providers.javascript.model.Manifest;
 import com.redhat.exhort.sbom.Sbom;
+import com.redhat.exhort.tools.Operations;
 import java.nio.file.Path;
 import java.util.Map;
 import java.util.TreeMap;
@@ -36,6 +37,7 @@ public YarnBerryProcessor(String packageManager, Manifest manifest) {
     super(packageManager, manifest);
   }
 
+  @Override
   public String[] installCmd(Path manifestDir) {
     if (manifestDir != null) {
       return new String[] {
@@ -89,7 +91,9 @@ private boolean isRoot(String name) {
 
   @Override
   public String parseDepTreeOutput(String output) {
-    return "[" + output.trim().replace(System.lineSeparator(), "").replace("}{", "},{") + "]";
+    return "["
+        + output.trim().replaceAll(Operations.GENERIC_LINE_SEPARATOR, "").replace("}{", "},{")
+        + "]";
   }
 
   private PackageURL purlFromNode(String normalizedLocator, JsonNode node) {

src/main/java/com/redhat/exhort/tools/Operations.java

@@ -35,6 +35,9 @@
 /** Utility class used for executing process on the operating system. * */
 public final class Operations {
 
+  // Some package providers might return Unix output in Windows, so we need to use a generic line
+  // separator
+  public static final String GENERIC_LINE_SEPARATOR = "\\r?\\n";
   private static final Logger log = LoggersFactory.getLogger(Operations.class.getName());
 
   private Operations() {