fix: inline lazy endpoint resolution and document IllegalStateException

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: soul2zimate

src/main/java/io/github/guacsec/trustifyda/Api.java

@@ -131,6 +131,7 @@ CompletableFuture<Map<ImageRef, AnalysisReport>> imageAnalysis(Set<ImageRef> ima
    * @param manifestFile the path for the manifest file
    * @return the CycloneDX JSON SBOM content as a String
    * @throws IOException when failed to load the manifest file
+   * @throws IllegalStateException when the manifest file type is not supported
    */
   String generateSbom(String manifestFile) throws IOException;
 }

src/main/java/io/github/guacsec/trustifyda/impl/ExhortApi.java

@@ -86,7 +86,10 @@ public final class ExhortApi implements Api {
   private String endpoint;
 
   public String getEndpoint() {
-    return getOrResolveEndpoint();
+    if (this.endpoint == null) {
+      this.endpoint = getExhortUrl();
+    }
+    return this.endpoint;
   }
 
   private final HttpClient client;
@@ -162,13 +165,6 @@ private static String getClientRequestId() {
     return RequestManager.getInstance().getTraceIdOfRequest();
   }
 
-  private String getOrResolveEndpoint() {
-    if (this.endpoint == null) {
-      this.endpoint = getExhortUrl();
-    }
-    return this.endpoint;
-  }
-
   private String getExhortUrl() {
     String endpoint = Environment.get(TRUSTIFY_DA_BACKEND_URL);
     if (endpoint == null || endpoint.trim().isEmpty()) {
@@ -352,7 +348,7 @@ public CompletableFuture<AnalysisReport> componentAnalysis(
     String exClientTraceId = commonHookBeginning(false);
     var manifestPath = Path.of(manifest);
     var provider = Ecosystem.getProvider(manifestPath);
-    var uri = URI.create(String.format(S_API_V_5_ANALYSIS, getOrResolveEndpoint()));
+    var uri = URI.create(String.format(S_API_V_5_ANALYSIS, getEndpoint()));
     var content = provider.provideComponent();
     commonHookAfterProviderCreatedSbomAndBeforeExhort();
     return getAnalysisReportForComponent(uri, content, exClientTraceId);
@@ -396,7 +392,7 @@ public CompletableFuture<AnalysisReport> componentAnalysis(String manifestFile)
     String exClientTraceId = commonHookBeginning(false);
     var manifestPath = Path.of(manifestFile);
     var provider = Ecosystem.getProvider(manifestPath);
-    var uri = URI.create(String.format(S_API_V_5_ANALYSIS, getOrResolveEndpoint()));
+    var uri = URI.create(String.format(S_API_V_5_ANALYSIS, getEndpoint()));
     var content = provider.provideComponent();
     commonHookAfterProviderCreatedSbomAndBeforeExhort();
     return getAnalysisReportForComponent(uri, content, exClientTraceId);
@@ -437,7 +433,7 @@ private HttpRequest buildStackRequest(final String manifestFile, final MediaType
       throws IOException {
     var manifestPath = Path.of(manifestFile);
     var provider = Ecosystem.getProvider(manifestPath);
-    var uri = URI.create(String.format(S_API_V_5_ANALYSIS, getOrResolveEndpoint()));
+    var uri = URI.create(String.format(S_API_V_5_ANALYSIS, getEndpoint()));
     var content = provider.provideStack();
     commonHookAfterProviderCreatedSbomAndBeforeExhort();
 
@@ -524,7 +520,7 @@ <H, T> CompletableFuture<T> performBatchAnalysis(
       final String analysisName)
       throws IOException {
     String exClientTraceId = commonHookBeginning(false);
-    var uri = URI.create(String.format(S_API_V_5_BATCH_ANALYSIS, getOrResolveEndpoint()));
+    var uri = URI.create(String.format(S_API_V_5_BATCH_ANALYSIS, getEndpoint()));
     var sboms = sbomsGenerator.get();
     var content =
         new Provider.Content(
@@ -586,7 +582,7 @@ public CompletableFuture<ComponentAnalysisResult> componentAnalysisWithLicense(
     String exClientTraceId = commonHookBeginning(false);
     var manifestPath = Path.of(manifestFile);
     var provider = Ecosystem.getProvider(manifestPath);
-    var uri = URI.create(String.format(S_API_V_5_ANALYSIS, getOrResolveEndpoint()));
+    var uri = URI.create(String.format(S_API_V_5_ANALYSIS, getEndpoint()));
     var content = provider.provideComponent();
     String sbomJson = new String(content.buffer);
     commonHookAfterProviderCreatedSbomAndBeforeExhort();
@@ -617,7 +613,7 @@ public CompletableFuture<ComponentAnalysisResult> componentAnalysisWithLicense(
    */
   public CompletableFuture<JsonNode> getLicenseDetails(String spdxId) {
     String encodedId = URLEncoder.encode(spdxId, StandardCharsets.UTF_8).replace("+", "%20");
-    URI uri = URI.create(String.format(S_API_V5_LICENSES, getOrResolveEndpoint(), encodedId));
+    URI uri = URI.create(String.format(S_API_V5_LICENSES, getEndpoint(), encodedId));
     HttpRequest request = buildGetRequest(uri, "License Details");
 
     return this.client
@@ -663,7 +659,7 @@ public CompletableFuture<String> identifyLicense(Path licenseFilePath) {
       LOG.warning(String.format("Failed to read license file: %s", e.getMessage()));
       return CompletableFuture.completedFuture(null);
     }
-    URI uri = URI.create(String.format(S_API_V5_LICENSES_IDENTIFY, getOrResolveEndpoint()));
+    URI uri = URI.create(String.format(S_API_V5_LICENSES_IDENTIFY, getEndpoint()));
     HttpRequest request =
         buildPostRequest(
             uri,