Commit adf3b10
fix: address code review feedback for requirements.txt preprocessing
- Revert getIgnoredDependencies to use raw lines so ignore markers
(e.g. #trustify-da-ignore) in inline comments are not stripped
before containsIgnorePattern runs; keep \R split fix
- Use compiled Pattern with \s-- for inline option stripping to handle
tabs and multiple spaces, not just single space
- Add Windows drive-letter path filtering (C:\path, c:/path)
- Tighten :// URL check to only inspect the requirement part before
markers, avoiding false positives from marker strings
- Add tests for Windows paths and final-line backslash edge case
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 3dc259a commit adf3b10
3 files changed
Lines changed: 38 additions & 10 deletions
File tree
- src
- main/java/io/github/guacsec/trustifyda
- providers
- utils
- test/java/io/github/guacsec/trustifyda/utils
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | | - | |
100 | | - | |
| 98 | + | |
| 99 | + | |
101 | 100 | | |
102 | 101 | | |
103 | 102 | | |
| |||
Lines changed: 17 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
| 39 | + | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
372 | 374 | | |
373 | 375 | | |
374 | 376 | | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
375 | 380 | | |
376 | 381 | | |
377 | 382 | | |
| |||
404 | 409 | | |
405 | 410 | | |
406 | 411 | | |
407 | | - | |
408 | | - | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
409 | 417 | | |
410 | 418 | | |
411 | 419 | | |
| |||
414 | 422 | | |
415 | 423 | | |
416 | 424 | | |
417 | | - | |
418 | | - | |
419 | | - | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
420 | 428 | | |
421 | | - | |
422 | | - | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
423 | 433 | | |
424 | 434 | | |
425 | 435 | | |
| |||
Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2164 | 2164 | | |
2165 | 2165 | | |
2166 | 2166 | | |
| 2167 | + | |
| 2168 | + | |
| 2169 | + | |
| 2170 | + | |
| 2171 | + | |
| 2172 | + | |
| 2173 | + | |
| 2174 | + | |
| 2175 | + | |
| 2176 | + | |
| 2177 | + | |
| 2178 | + | |
| 2179 | + | |
| 2180 | + | |
| 2181 | + | |
| 2182 | + | |
| 2183 | + | |
| 2184 | + | |
| 2185 | + | |
2167 | 2186 | | |
2168 | 2187 | | |
2169 | 2188 | | |
| |||
0 commit comments