fix: allow missing go env vars

Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>

Author: ruromero

src/main/java/com/redhat/exhort/providers/GoModulesProvider.java

@@ -40,6 +40,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
+import java.util.Optional;
 import java.util.TreeMap;
 import java.util.logging.Logger;
 import java.util.regex.Pattern;
@@ -52,6 +53,7 @@
 public final class GoModulesProvider extends Provider {
 
   public static final String PROP_EXHORT_GO_MVS_LOGIC_ENABLED = "EXHORT_GO_MVS_LOGIC_ENABLED";
+  private static final String GO_BINARY = "go";
   private static final Logger log = LoggersFactory.getLogger(GoModulesProvider.class.getName());
   private static final String GO_HOST_ARCHITECTURE_ENV_NAME = "GOHOSTARCH";
   private static final String GO_HOST_OPERATION_SYSTEM_ENV_NAME = "GOHOSTOS";
@@ -67,8 +69,8 @@ public String getMainModuleVersion() {
 
   public GoModulesProvider(Path manifest) {
     super(Type.GOLANG, manifest);
-    this.goExecutable = Operations.getExecutable("go", "version");
-    this.goEnvironmentVariableForPurl = getQualifiers(true);
+    this.goExecutable = Operations.getExecutable(GO_BINARY, "version");
+    this.goEnvironmentVariableForPurl = getQualifiers();
     this.mainModuleVersion = getDefaultMainModuleVersion();
   }
 
@@ -320,9 +322,9 @@ private Sbom buildSbomFromGraph(
 
   private Map<String, List<String>> getFinalPackagesVersionsForModule(
       Map<String, List<String>> edges, Path manifestPath) {
-    Operations.runProcessGetOutput(manifestPath.getParent(), "go", "mod", "download");
+    Operations.runProcessGetOutput(manifestPath.getParent(), GO_BINARY, "mod", "download");
     String finalVersionsForAllModules =
-        Operations.runProcessGetOutput(manifestPath.getParent(), "go", "list", "-m", "all");
+        Operations.runProcessGetOutput(manifestPath.getParent(), GO_BINARY, "list", "-m", "all");
     Map<String, String> finalModulesVersions =
         Arrays.stream(finalVersionsForAllModules.split(System.lineSeparator()))
             .filter(string -> string.trim().split(" ").length == 2)
@@ -378,26 +380,32 @@ private static List<String> collectAllDirectDependencies(List<String> targetLine
         .collect(Collectors.toList());
   }
 
-  private TreeMap<String, String> getQualifiers(boolean includeOsAndArch) {
-    if (includeOsAndArch) {
-      String goEnvironmentVariables = Operations.runProcessGetOutput(null, goExecutable, "env");
-      String hostArch =
-          getEnvironmentVariable(goEnvironmentVariables, GO_HOST_ARCHITECTURE_ENV_NAME);
-      String hostOS =
-          getEnvironmentVariable(goEnvironmentVariables, GO_HOST_OPERATION_SYSTEM_ENV_NAME);
-      return new TreeMap<>(Map.of("type", "module", "goos", hostOS, "goarch", hostArch));
+  private TreeMap<String, String> getQualifiers() {
+    String goEnvironmentVariables = Operations.runProcessGetOutput(null, goExecutable, "env");
+    var hostArch = getEnvironmentVariable(goEnvironmentVariables, GO_HOST_ARCHITECTURE_ENV_NAME);
+    var hostOS = getEnvironmentVariable(goEnvironmentVariables, GO_HOST_OPERATION_SYSTEM_ENV_NAME);
+    var qualifiers = new TreeMap<String, String>();
+    qualifiers.put("type", "module");
+    if (hostOS.isPresent()) {
+      qualifiers.put("goos", hostOS.get());
     }
-
-    return new TreeMap<>(Map.of("type", "module"));
+    if (hostArch.isPresent()) {
+      qualifiers.put("goarch", hostArch.get());
+    }
+    return qualifiers;
   }
 
-  private static String getEnvironmentVariable(String goEnvironmentVariables, String envName) {
+  private static Optional<String> getEnvironmentVariable(
+      String goEnvironmentVariables, String envName) {
     int i = goEnvironmentVariables.indexOf(String.format("%s=", envName));
+    if (i == -1) {
+      return Optional.empty();
+    }
     int beginIndex = i + String.format("%s=", envName).length();
     int endOfLineIndex =
         goEnvironmentVariables.substring(beginIndex).indexOf(System.lineSeparator());
     String envValue = goEnvironmentVariables.substring(beginIndex).substring(0, endOfLineIndex);
-    return envValue.replaceAll("\"", "");
+    return Optional.of(envValue.replaceAll("\"", ""));
   }
 
   private String buildGoModulesDependencies(Path manifestPath) {

src/main/java/com/redhat/exhort/providers/JavaMavenProvider.java

@@ -372,7 +372,7 @@ public int hashCode() {
   private String selectMvnRuntime(final Path manifestPath) {
     boolean preferWrapper = Operations.getWrapperPreference(MVN);
     if (preferWrapper) {
-      String wrapperName = isWindows() ? "mvnw.cmd" : "mvnw";
+      String wrapperName = Operations.isWindows() ? "mvnw.cmd" : "mvnw";
       String mvnw = traverseForMvnw(wrapperName, manifestPath.toString());
       if (mvnw != null) {
         try {
@@ -423,13 +423,9 @@ public static String traverseForMvnw(
   public static String normalizePath(String thePath) {
     Path normalized = Paths.get(thePath).toAbsolutePath().normalize();
     String result = normalized.toString();
-    if (isWindows()) {
+    if (Operations.isWindows()) {
       result = result.toLowerCase();
     }
     return result;
   }
-
-  private static boolean isWindows() {
-    return System.getProperty("os.name").toLowerCase().contains("win");
-  }
 }

src/main/java/com/redhat/exhort/providers/JavaScriptYarnProvider.java

@@ -33,9 +33,9 @@
 public final class JavaScriptYarnProvider extends JavaScriptProvider {
 
   public static final String LOCK_FILE = "yarn.lock";
-  public static final String CMD_NAME = "yarn";
+  public static final String CMD_NAME = Operations.isWindows() ? "yarn.cmd" : "yarn";
 
-  private static final Pattern versionPattern = Pattern.compile("^([0-9]+)\\.");
+  private static final Pattern VERSION_PATTERN = Pattern.compile("^([0-9]+)\\.");
 
   private final YarnProcessor processor;
 
@@ -79,7 +79,7 @@ private YarnProcessor resolveVersion(Path manifestPath) {
     var output =
         Operations.runProcessGetOutput(
             manifestPath.getParent(), new String[] {cmd, "-v"}, getExecEnvAsArgs());
-    var matcher = versionPattern.matcher(output);
+    var matcher = VERSION_PATTERN.matcher(output);
     if (matcher.find()) {
       var majorVersion = Integer.parseInt(matcher.group(1));
       if (majorVersion == 1) {

src/main/java/com/redhat/exhort/tools/Operations.java

@@ -349,4 +349,8 @@ public static Optional<String> getGitRootDir(String cwd) {
     }
     return Optional.empty();
   }
+
+  public static boolean isWindows() {
+    return System.getProperty("os.name").toLowerCase().contains("win");
+  }
 }