fix: support windows binary for yarn and go

Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>

Author: ruromero

src/main/java/com/redhat/exhort/providers/GoModulesProvider.java

@@ -52,6 +52,7 @@
 public final class GoModulesProvider extends Provider {
 
   public static final String PROP_EXHORT_GO_MVS_LOGIC_ENABLED = "EXHORT_GO_MVS_LOGIC_ENABLED";
+  private static final String GO_BINARY = Operations.isWindows() ? "go.cmd" : "go";
   private static final Logger log = LoggersFactory.getLogger(GoModulesProvider.class.getName());
   private static final String GO_HOST_ARCHITECTURE_ENV_NAME = "GOHOSTARCH";
   private static final String GO_HOST_OPERATION_SYSTEM_ENV_NAME = "GOHOSTOS";
@@ -67,7 +68,7 @@ public String getMainModuleVersion() {
 
   public GoModulesProvider(Path manifest) {
     super(Type.GOLANG, manifest);
-    this.goExecutable = Operations.getExecutable("go", "version");
+    this.goExecutable = Operations.getExecutable(GO_BINARY, "version");
     this.goEnvironmentVariableForPurl = getQualifiers(true);
     this.mainModuleVersion = getDefaultMainModuleVersion();
   }
@@ -320,9 +321,9 @@ private Sbom buildSbomFromGraph(
 
   private Map<String, List<String>> getFinalPackagesVersionsForModule(
       Map<String, List<String>> edges, Path manifestPath) {
-    Operations.runProcessGetOutput(manifestPath.getParent(), "go", "mod", "download");
+    Operations.runProcessGetOutput(manifestPath.getParent(), GO_BINARY, "mod", "download");
     String finalVersionsForAllModules =
-        Operations.runProcessGetOutput(manifestPath.getParent(), "go", "list", "-m", "all");
+        Operations.runProcessGetOutput(manifestPath.getParent(), GO_BINARY, "list", "-m", "all");
     Map<String, String> finalModulesVersions =
         Arrays.stream(finalVersionsForAllModules.split(System.lineSeparator()))
             .filter(string -> string.trim().split(" ").length == 2)

src/main/java/com/redhat/exhort/providers/JavaMavenProvider.java

@@ -54,7 +54,7 @@ public final class JavaMavenProvider extends BaseJavaProvider {
   private static final String PROP_JAVA_HOME = "JAVA_HOME";
   private static final Logger log = LoggersFactory.getLogger(JavaMavenProvider.class.getName());
   private final String mvnExecutable;
-  private static final String MVN = isWindows() ? "mvn.cmd" : "mvn";
+  private static final String MVN = Operations.isWindows() ? "mvn.cmd" : "mvn";
   private static final String ARG_VERSION = "-v";
 
   public JavaMavenProvider(Path manifest) {
@@ -423,13 +423,9 @@ public static String traverseForMvnw(
   public static String normalizePath(String thePath) {
     Path normalized = Paths.get(thePath).toAbsolutePath().normalize();
     String result = normalized.toString();
-    if (isWindows()) {
+    if (Operations.isWindows()) {
       result = result.toLowerCase();
     }
     return result;
   }
-
-  private static boolean isWindows() {
-    return System.getProperty("os.name").toLowerCase().contains("win");
-  }
 }

src/main/java/com/redhat/exhort/providers/JavaScriptYarnProvider.java

@@ -33,7 +33,7 @@
 public final class JavaScriptYarnProvider extends JavaScriptProvider {
 
   public static final String LOCK_FILE = "yarn.lock";
-  public static final String CMD_NAME = "yarn";
+  public static final String CMD_NAME = Operations.isWindows() ? "yarn.cmd" : "yarn";
 
   private static final Pattern versionPattern = Pattern.compile("^([0-9]+)\\.");
 

src/main/java/com/redhat/exhort/tools/Operations.java

@@ -349,4 +349,8 @@ public static Optional<String> getGitRootDir(String cwd) {
     }
     return Optional.empty();
   }
+
+  public static boolean isWindows() {
+    return System.getProperty("os.name").toLowerCase().contains("win");
+  }
 }