chore: add better test coverage

Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>

Author: ruromero

src/main/java/com/redhat/exhort/cli/App.java

@@ -15,9 +15,12 @@
  */
 package com.redhat.exhort.cli;
 
-import static com.redhat.exhort.cli.AppUtils.exitWithError;
-import static com.redhat.exhort.cli.AppUtils.printException;
-import static com.redhat.exhort.cli.AppUtils.printLine;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
 
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.core.JsonProcessingException;
@@ -26,13 +29,10 @@
 import com.redhat.exhort.api.v4.AnalysisReport;
 import com.redhat.exhort.api.v4.ProviderReport;
 import com.redhat.exhort.api.v4.Source;
+import static com.redhat.exhort.cli.AppUtils.exitWithError;
+import static com.redhat.exhort.cli.AppUtils.printException;
+import static com.redhat.exhort.cli.AppUtils.printLine;
 import com.redhat.exhort.impl.ExhortApi;
-import java.io.IOException;
-import java.nio.file.Files;
-import java.nio.file.Path;
-import java.nio.file.Paths;
-import java.util.concurrent.CompletableFuture;
-import java.util.concurrent.ExecutionException;
 
 public class App {
 
@@ -81,7 +81,10 @@ private static CliArgs parseArgs(String[] args) {
 
     Path path = validateFile(args[1]);
 
-    OutputFormat outputFormat = parseOutputFormat(command, args[2]);
+    OutputFormat outputFormat = OutputFormat.JSON;
+    if(args.length == 3) {
+      outputFormat = parseOutputFormat(command, args[2]);
+    }
 
     return new CliArgs(command, path, outputFormat);
   }
@@ -99,10 +102,6 @@ private static Command parseCommand(String commandStr) {
   }
 
   private static OutputFormat parseOutputFormat(Command command, String formatArg) {
-    if (formatArg == null) {
-      return OutputFormat.JSON;
-    }
-
     switch (formatArg) {
       case "--summary":
         return OutputFormat.SUMMARY;
@@ -125,9 +124,6 @@ private static Path validateFile(String filePath) {
     if (!Files.isRegularFile(path)) {
       throw new IllegalArgumentException("File is not a regular file: " + filePath);
     }
-    if (!Files.isReadable(path)) {
-      throw new IllegalArgumentException("File is not readable: " + filePath);
-    }
     return path;
   }
 

src/main/java/com/redhat/exhort/cli/AppUtils.java

@@ -20,10 +20,6 @@ public static void exitWithError() {
     System.exit(1);
   }
 
-  public static void exitWithSuccess() {
-    System.exit(0);
-  }
-
   public static void printLine(String message) {
     System.out.println(message);
   }