chore: remove exhort_dev_mode and default endpoints and use value from environment variables or arguments#211
Merged
Conversation
ruromero
requested changes
Nov 18, 2025
ruromero
left a comment
ruromero
left a comment
Collaborator
There was a problem hiding this comment.
Only 2 remarks. The implementation is correct.
- Remove the backend-url from the cli arguments to match the JS functionality and only rely on env vars.
- Remove the default value for prod. No default value should be set and it should fail when it's not set.
…m environment variables
soul2zimate
force-pushed
the
dev_endpoint_main
branch
from
November 18, 2025 11:19
1867682 to
0a1a2b3
Compare
Contributor
Author
Thanks for the review and suggestion. I have updated the solution. |
ruromero
requested changes
Nov 18, 2025
ruromero
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
chore: remove exhort_dev_mode and default endpoints and use value from environment variables or arguments
Related issue (if any): fixes #210
Checklist