Skip to content

build: bump com.diffplug.spotless:spotless-maven-plugin from 2.44.4 to 3.2.1#280

Merged
soul2zimate merged 1 commit into
guacsec:mainfrom
soul2zimate:bump_spotless
Feb 5, 2026
Merged

build: bump com.diffplug.spotless:spotless-maven-plugin from 2.44.4 to 3.2.1#280
soul2zimate merged 1 commit into
guacsec:mainfrom
soul2zimate:bump_spotless

Conversation

@soul2zimate

Copy link
Copy Markdown
Contributor

Description

build: bump com.diffplug.spotless:spotless-maven-plugin from 2.44.4 to 3.2.1
replace #278

@qodo-code-review

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Upgrade spotless-maven-plugin to 3.2.1

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Upgrade spotless-maven-plugin from 2.44.4 to 3.2.1
• Apply code formatting changes from upgraded plugin
Diagram
flowchart LR
  A["spotless-maven-plugin 2.44.4"] -- "upgrade" --> B["spotless-maven-plugin 3.2.1"]
  B -- "apply formatting" --> C["Code formatting updates"]
Loading

Grey Divider

File Changes

1. pom.xml Dependencies +1/-1

Bump spotless-maven-plugin version

• Update spotless-maven-plugin.version property from 2.44.4 to 3.2.1

pom.xml


2. src/test/java/io/github/guacsec/trustifyda/providers/CargoProviderCargoParsingTest.java Formatting +1/-1

Apply spotless formatting to test file

• Reformat multi-line string literal to align with new spotless formatting rules
• Adjust indentation of triple-quoted string from indented to flush-left position

src/test/java/io/github/guacsec/trustifyda/providers/CargoProviderCargoParsingTest.java


Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. Spotless bump may break CI 🐞 Bug ⛯ Reliability
Description
• The PR changes the Spotless Maven plugin version; Spotless is bound to process-sources with goal
  check, so any incompatibility (plugin resolution, config schema changes, or formatter behavior
  changes) will fail mvn verify and block PR/release pipelines.
• Since CI runs mvn verify (not a dedicated formatting step), this change impacts all contributors
  immediately; ensure the version bump is intentional and that the repository is formatted according
  to the new Spotless/formatter behavior.
Code

pom.xml[60]

+    <spotless-maven-plugin.version>3.2.1</spotless-maven-plugin.version>
Evidence
The pom pins Spotless to 3.2.1, and the build config executes spotless:check during
process-sources. The PR workflow runs mvn verify, which will execute process-sources;
therefore any Spotless/plugin/config mismatch will fail CI early.

pom.xml[54-62]
pom.xml[760-795]
.github/workflows/pr.yml[50-56]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The Spotless Maven plugin version was changed, and Spotless is executed automatically (`spotless:check` in `process-sources`). If the new version changes formatter behavior or configuration compatibility, CI (`mvn verify`) will fail for all PRs.

## Issue Context
This repo runs Spotless during the standard build lifecycle, not as an opt-in step.

## Fix Focus Areas
- pom.xml[54-62]
- pom.xml[760-795]
- .github/workflows/pr.yml[50-56]

## Suggested steps
1. Run `mvn -B verify -Pits,cov` locally (matching CI) to confirm Spotless executes successfully.
2. If Spotless reports formatting violations due to formatter behavior changes, run Spotless apply, commit the reformat, and keep the bump.
3. If configuration incompatibilities appear, adjust the Spotless configuration accordingly (or revert the version change if unintended).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@soul2zimate
soul2zimate requested a review from ruromero February 5, 2026 00:53
@soul2zimate
soul2zimate merged commit 0dbcca1 into guacsec:main Feb 5, 2026
24 of 39 checks passed
@soul2zimate
soul2zimate deleted the bump_spotless branch February 5, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants