fix: filter toolchain entries in GoModulesProvider#387
Merged
Conversation
isGoToolchainEntry() now matches both go@* and toolchain@* entries, aligning with the JS client's isSpecialGoModule() behavior. TC-3919 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ruromero
enabled auto-merge (squash)
March 30, 2026 23:33
soul2zimate
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isGoToolchainEntry()now filters bothgo@*andtoolchain@*entries from Go SBOMs, aligning with the JS client'sisSpecialGoModule()behaviorCloses TC-3919
Test plan
test_isGoToolchainEntry_filters_go_and_toolchainpassesmvn verifypasses🤖 Generated with Claude Code