Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ jobs:
checks: write
pull-requests: write
env:
MAIN_JAVA_VER: 17
MAIN_JAVA_VER: 21
RUN_PYTHON_BIN: ${{ vars.RUN_PYTHON_BIN }}
strategy:
matrix:
java: [17, 21]
java: [21]
steps:
- name: Checkout sources
uses: actions/checkout@v6
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v6

- name: Set up Java 17
- name: Set up Java 21
uses: actions/setup-java@v5
with:
java-version: '17'
java-version: '21'
distribution: 'temurin'
cache: 'maven'
gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,4 +113,4 @@ contribution. See the [DCO](DCO) file for details.
[1]: https://github.com/guacsec/trustify-da-api-spec/blob/main/api/v5/openapi.yaml

<!-- Badge links -->
[10]: https://badgen.net/badge/Java%20Version/11/5382a1
[10]: https://badgen.net/badge/Java%20Version/21/5382a1
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
* Looking for our JavaScript/TypeScript API? Try [Trustify DA JavaScript Client](https://github.com/guacsec/trustify-da-javascript-client).
* Looking for our Backend implementation? Try [Trustify Dependency Analytics](https://github.com/guacsec/trustify-dependency-analytics).

**Requires Java 21 or later.**

The _Trustify DA Java Client_ module is deployed to _GitHub Package Registry_.

<details>
Expand Down Expand Up @@ -824,10 +826,9 @@ Released artifacts are available on [Maven Central](https://repo1.maven.org/mave



- For maven pom.xml, it has been noticed that using java 17 might cause stack analysis to hang forever.
This is caused by maven [`dependency` Plugin](https://maven.apache.org/plugins/maven-dependency-plugin/) bug when running with JDK/JRE' JVM version 17.

To overcome this, you can use any other java version (14,20,21, etc..). ( best way is to install JDK/JRE version different from 17 , and set the location of the installation in environment variable `JAVA_HOME` so maven will use it.)
- For maven pom.xml, it has been noticed that using Java 17 might cause stack analysis to hang forever.
This is caused by maven [`dependency` Plugin](https://maven.apache.org/plugins/maven-dependency-plugin/) bug when running with JDK/JRE JVM version 17.
This project now requires Java 21 as the minimum version, which is not affected by this issue.


<!-- Badge links -->
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<code.coverage.threshold>81%</code.coverage.threshold>
<mutation.coverage.threshold>50</mutation.coverage.threshold>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.release>17</maven.compiler.release>
<maven.compiler.release>21</maven.compiler.release>
Comment thread
qodo-code-review[bot] marked this conversation as resolved.
<!-- Dependencies -->
<trustify-da-api-model.version>2.0.7</trustify-da-api-model.version>
<jackson.version>2.21.2</jackson.version>
Expand Down Expand Up @@ -628,7 +628,7 @@ limitations under the License.]]>
<rules>
<dependencyConvergence />
<requireJavaVersion>
<version>[11,)</version>
<version>[21,)</version>
</requireJavaVersion>
<requireMavenVersion>
<version>[3.8,)</version>
Expand Down
Loading