ci: fix dependabot exclusions for non-production ecosystems#431
Merged
Conversation
The dependabot config missed /src/test/resources/msc/python in the pip ecosystem exclusion, allowing security update PR guacsec#425 (mako bump) to be created for an intentionally-pinned test fixture. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ruromero
enabled auto-merge (squash)
April 21, 2026 15:17
Per-directory entries with /** globs don't reliably suppress security updates (PRs guacsec#424, guacsec#426, guacsec#427 appeared after guacsec#422 was merged). Since this repo has no production npm/pip/go/gradle/cargo dependencies, add root-level entries with ignore-all + open-pull-requests-limit: 0 as a catch-all for security updates that bypass per-directory matching. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ruromero
changed the title
Strum355
approved these changes
Apr 22, 2026
3 tasks
ruromero
added a commit
to ruromero/trustify-da-java-client
that referenced
this pull request
Apr 30, 2026
Add root-level `ignore: [{dependency-name: "*"}]` for the uv
ecosystem, missed in PR guacsec#431. Remove redundant per-directory entries
for ecosystems covered by root-level ignore-all. Replace glob
patterns with explicit directory listings for maven test fixtures,
since `/**` globs don't reliably match nested subdirectories for
security updates.
Add test fixture guidance to CONVENTIONS.md.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ruromero
added a commit
that referenced
this pull request
Apr 30, 2026
## Summary
- Add root-level `ignore: [{dependency-name: "*"}]` for the uv ecosystem
(missed in PR #431)
- Remove redundant per-directory entries for ecosystems covered by
root-level ignore-all
- Replace `/**` glob patterns with explicit directory listings for maven
test fixtures
- Add test fixture dependabot guidance to CONVENTIONS.md
## Context
PR #431 added root-level ignore-all for npm, pip, gomod, gradle, cargo
but missed `uv`, causing Dependabot to create security PRs for
pyproject.toml files in test fixtures (#439, #440, #441). Glob patterns
are replaced with explicit paths since `/**` doesn't reliably match
nested subdirectories for security updates.
## Test plan
- [ ] Verify uv security PRs (#439, #440, #441) are closed by Dependabot
- [ ] Verify no new security PRs appear for test fixture directories
- [ ] Verify production maven dependency updates still work normally
🤖 Generated with [Claude Code](https://claude.com/claude-code)
## Summary by Sourcery
Update Dependabot configuration to correctly suppress updates for test
fixtures while preserving production maven updates, and document project
coding and Dependabot conventions.
Bug Fixes:
- Add root-level ignore-all entry for the uv ecosystem so Dependabot
does not open security PRs for uv-based test fixtures.
Enhancements:
- Simplify Dependabot configuration by relying on root-level ignore-all
entries for non-maven ecosystems and consolidating cargo configuration.
- Restrict Dependabot handling of maven test fixtures to an explicit
list of fixture directories to ensure they are not updated while keeping
production maven updates active.
CI:
- Adjust .github/dependabot.yml to correct ecosystem entries and
explicitly list maven test fixture directories for suppression.
Documentation:
- Add CONVENTIONS.md to document coding standards, dependencies, and
guidance for managing Dependabot suppression of test fixtures.
---------
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignore: [{dependency-name: "*"}]entries for all non-production ecosystems (npm, pip, gomod, gradle, cargo) to suppress security updates that bypass per-directory glob matching/src/test/resources/msc/pythonto thepipecosystem exclusion (missed in ci: suppress dependabot updates for test fixture manifests #422)Why root-level entries?
Per-directory entries with
/**globs don't reliably suppress security updates — PRs #424, #426, #427 (axios bumps init/npm,it/pnpm,it/yarn) were all created after #422 was merged. Since this repo has no production npm/pip/go/gradle/cargo dependencies, root-level entries withignore-all+open-pull-requests-limit: 0act as a catch-all.The existing per-directory entries are kept for version update suppression.
Test plan
🤖 Generated with Claude Code