fix: replace pnpm to npm install#436
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate the GitHub Actions release workflow to install pnpm globally using npm instead of invoking pnpm directly, ensuring pnpm is available even on environments where it is not preinstalled. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider pinning the pnpm version (or using
corepack enable pnpmwith setup-node) instead of installing the latest globally vianpm install -g pnpmto avoid unexpected breakage from upstream pnpm changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider pinning the pnpm version (or using `corepack enable pnpm` with setup-node) instead of installing the latest globally via `npm install -g pnpm` to avoid unexpected breakage from upstream pnpm changes.
## Individual Comments
### Comment 1
<location path=".github/workflows/release.yml" line_range="95" />
<code_context>
- name: Install pnpm
- run: pnpm install -g pnpm
+ run: npm install -g pnpm
- name: Compute Maven profiles
</code_context>
<issue_to_address>
**suggestion:** Consider pinning pnpm to a specific version or using the official setup action for reproducible builds.
Using `npm install -g pnpm` without a version will always fetch the latest release, which can cause non-deterministic changes in your CI over time. Pin a specific pnpm version or use `pnpm/action-setup` with an explicit version to keep the release workflow stable across runs.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ruromero
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue (if any): fixes #issue_number_goes_here
Checklist
Additional information
Summary by Sourcery
CI: