Skip to content

fix(go): handle replace directives in go list -m all parsing #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruromero merged 3 commits into from
May 12, 2026
Merged

fix(go): handle replace directives in go list -m all parsing #468

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ab7599
fix(go): handle replace directives in go list -m all parsing
a-oren May 12, 2026
8dfee73
Merge remote-tracking branch 'upstream/main' into TC-4359
a-oren May 12, 2026
8628bff
fix(go): split on \s+ in parseModuleVersions and add unit tests
a-oren May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/main/java/io/github/guacsec/trustifyda/providers/GoModulesProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,12 +347,7 @@ private Map<String, List<String>> getFinalPackagesVersionsForModule(
Operations.runProcessGetOutput(manifestPath.getParent(), goExecutable, "mod", "download");
String finalVersionsForAllModules =
Operations.runProcessGetOutput(manifestPath.getParent(), goExecutable, "list", "-m", "all");
Map<String, String> finalModulesVersions =
Arrays.stream(finalVersionsForAllModules.split(Operations.GENERIC_LINE_SEPARATOR))
.filter(string -> string.trim().split(" ").length == 2)
.collect(
Collectors.toMap(
t -> t.split(" ")[0], t -> t.split(" ")[1], (first, second) -> second));
Map<String, String> finalModulesVersions = parseModuleVersions(finalVersionsForAllModules);
Map<String, List<String>> listWithModifiedVersions = new HashMap<>();
// Process all entries, including those without versions (like the root module)
edges.forEach(
Expand Down Expand Up @@ -387,6 +382,24 @@ private Map<String, List<String>> getFinalPackagesVersionsForModule(
return listWithModifiedVersions;
}

/**
* Parses {@code go list -m all} output into a map of module names to their final resolved
* versions. Handles both standard lines ({@code name version}) and replace directive lines
* ({@code name v1 => replacement v2}).
*/
static Map<String, String> parseModuleVersions(String goListOutput) {
return Arrays.stream(goListOutput.split(Operations.GENERIC_LINE_SEPARATOR))
.map(String::trim)
.map(line -> line.split(" "))
.filter(parts -> parts.length == 2 || (parts.length >= 4 && parts[2].equals("=>")))
.collect(
Collectors.toMap(
parts -> parts[0],
parts ->
parts.length >= 4 && parts[2].equals("=>") ? parts[parts.length - 1] : parts[1],
(first, second) -> second));
}

private List<String> getListOfPackagesWithFinalVersions(
Map<String, String> finalModulesVersions, List<String> packages) {
return packages.stream()
Expand Down
8 changes: 4 additions & 4 deletions ...t/resources/tst_manifests/golang/go_mod_light_no_ignore/expected_sbom_stack_analysis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,11 @@
},
{
"type": "library",
"bom-ref": "pkg:golang/gopkg.in/yaml.v3@v3.0.1",
"bom-ref": "pkg:golang/gopkg.in/yaml.v3@v3.0.0",
"group": "gopkg.in",
"name": "yaml.v3",
"version": "v3.0.1",
"purl": "pkg:golang/gopkg.in/yaml.v3@v3.0.1"
"version": "v3.0.0",
"purl": "pkg:golang/gopkg.in/yaml.v3@v3.0.0"
},
{
"type": "library",
Expand Down Expand Up @@ -497,7 +497,7 @@
"dependsOn": []
},
{
"ref": "pkg:golang/gopkg.in/yaml.v3@v3.0.1",
"ref": "pkg:golang/gopkg.in/yaml.v3@v3.0.0",
"dependsOn": [
"pkg:golang/gopkg.in/check.v1@v0.0.0-20161208181325-20d25e280405"
]
Expand Down
2 changes: 2 additions & 0 deletions src/test/resources/tst_manifests/golang/go_mod_light_no_ignore/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ require golang.org/x/tools v0.0.0-20210112183307-1e6ecd4bf1b0
require github.com/spf13/cobra v0.0.5

require gopkg.in/yaml.v3 v3.0.1 // indirect

replace gopkg.in/yaml.v3 v3.0.1 => gopkg.in/yaml.v3 v3.0.0
Loading