feat(deps): bump trustify-da-api-model for recommendation schemas#519
Merged
Conversation
…dation schemas Update the api-model dependency to include the new RecommendationSource, RecommendationReport, and RecommendationSummary types. Add recommendations map to test fixtures at the ProviderReport level alongside existing sources, and update analysis-report.mixed to match the updated JSON fixture. Implements TC-4693 Assisted-by: Claude Code
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the trustify-da-api-model dependency to a new snapshot version that introduces recommendation-related schemas and aligns existing JSON test fixtures to the new ProviderReport structure by adding a recommendations map alongside sources. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider avoiding a
-SNAPSHOTversion fortrustify-da-api-modelinpom.xmland instead pinning to a released version (or documenting why a snapshot is required) to reduce build reproducibility and stability issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider avoiding a `-SNAPSHOT` version for `trustify-da-api-model` in `pom.xml` and instead pinning to a released version (or documenting why a snapshot is required) to reduce build reproducibility and stability issues.
## Individual Comments
### Comment 1
<location path="pom.xml" line_range="21" />
<code_context>
<maven.compiler.release>21</maven.compiler.release>
<!-- Dependencies -->
- <trustify-da-api-model.version>2.0.7</trustify-da-api-model.version>
+ <trustify-da-api-model.version>2.0.8-SNAPSHOT</trustify-da-api-model.version>
<jackson.version>2.21.3</jackson.version>
<jackson-annotations.version>2.21</jackson-annotations.version>
</code_context>
<issue_to_address>
**issue (bug_risk):** Using a SNAPSHOT dependency may introduce non-deterministic builds.
Relying on `2.0.8-SNAPSHOT` means builds can change whenever that snapshot is updated, which hurts reproducibility. If you need this for ongoing development, consider isolating it (e.g., in a dedicated snapshot profile) and plan to switch to a released version before this POM is used in CI or production pipelines.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Replace SNAPSHOT version with the published release now that v2.0.8 has been released to Maven Central. Implements TC-4693 Assisted-by: Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
=======================================
Coverage ? 68.22%
Complexity ? 987
=======================================
Files ? 65
Lines ? 4201
Branches ? 733
=======================================
Hits ? 2866
Misses ? 1002
Partials ? 333
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ruromero
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trustify-da-api-modelfrom 2.0.7 to 2.0.8-SNAPSHOT to include new recommendation schemas (RecommendationSource, RecommendationReport, RecommendationSummary)recommendationsmap to test fixtures (analysis-report.json,analysis-report.mixed,image_reports.json) at the ProviderReport level alongside existingsourcesImplements TC-4693
Test plan
mvn verify— 95/95 tests)🤖 Generated with Claude Code
Summary by Sourcery
Bump the trustify-da-api-model dependency to incorporate new recommendation-related schemas and update test fixtures to include recommendation data alongside existing sources.