Skip to content

feat(deps): bump trustify-da-api-model for recommendation schemas#519

Merged
a-oren merged 3 commits into
guacsec:mainfrom
a-oren:TC-4693
Jun 10, 2026
Merged

feat(deps): bump trustify-da-api-model for recommendation schemas#519
a-oren merged 3 commits into
guacsec:mainfrom
a-oren:TC-4693

Conversation

@a-oren

@a-oren a-oren commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bump trustify-da-api-model from 2.0.7 to 2.0.8-SNAPSHOT to include new recommendation schemas (RecommendationSource, RecommendationReport, RecommendationSummary)
  • Add recommendations map to test fixtures (analysis-report.json, analysis-report.mixed, image_reports.json) at the ProviderReport level alongside existing sources
  • All 95 existing tests pass with the updated model version

Implements TC-4693

Test plan

  • Full test suite passes (mvn verify — 95/95 tests)
  • Test fixtures deserialize correctly with new recommendation map structure
  • New model types (RecommendationSource, RecommendationReport, RecommendationSummary) available on classpath

🤖 Generated with Claude Code

Summary by Sourcery

Bump the trustify-da-api-model dependency to incorporate new recommendation-related schemas and update test fixtures to include recommendation data alongside existing sources.

…dation schemas

Update the api-model dependency to include the new RecommendationSource,
RecommendationReport, and RecommendationSummary types. Add recommendations
map to test fixtures at the ProviderReport level alongside existing sources,
and update analysis-report.mixed to match the updated JSON fixture.

Implements TC-4693

Assisted-by: Claude Code
@sourcery-ai

sourcery-ai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the trustify-da-api-model dependency to a new snapshot version that introduces recommendation-related schemas and aligns existing JSON test fixtures to the new ProviderReport structure by adding a recommendations map alongside sources.

File-Level Changes

Change Details Files
Upgrade trustify-da-api-model dependency to include new recommendation schemas and validate compatibility.
  • Bump trustify-da-api-model.version property from 2.0.7 to 2.0.8-SNAPSHOT in Maven pom.
  • Ensure the project still compiles and tests run against the updated model version.
pom.xml
Align test fixtures with new ProviderReport recommendation structure.
  • Update Maven analysis dummy response JSON to include a recommendations map at the ProviderReport level alongside existing sources.
  • Update mixed Maven analysis dummy response fixture to add the recommendations map consistent with the new schema.
  • Update image report dummy response JSON to populate recommendations at the appropriate level for the revised model.
src/test/resources/dummy_responses/maven/analysis-report.json
src/test/resources/dummy_responses/maven/analysis-report.mixed
src/test/resources/msc/image/image_reports.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Consider avoiding a -SNAPSHOT version for trustify-da-api-model in pom.xml and instead pinning to a released version (or documenting why a snapshot is required) to reduce build reproducibility and stability issues.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider avoiding a `-SNAPSHOT` version for `trustify-da-api-model` in `pom.xml` and instead pinning to a released version (or documenting why a snapshot is required) to reduce build reproducibility and stability issues.

## Individual Comments

### Comment 1
<location path="pom.xml" line_range="21" />
<code_context>
     <maven.compiler.release>21</maven.compiler.release>
     <!-- Dependencies -->
-    <trustify-da-api-model.version>2.0.7</trustify-da-api-model.version>
+    <trustify-da-api-model.version>2.0.8-SNAPSHOT</trustify-da-api-model.version>
     <jackson.version>2.21.3</jackson.version>
     <jackson-annotations.version>2.21</jackson-annotations.version>
</code_context>
<issue_to_address>
**issue (bug_risk):** Using a SNAPSHOT dependency may introduce non-deterministic builds.

Relying on `2.0.8-SNAPSHOT` means builds can change whenever that snapshot is updated, which hurts reproducibility. If you need this for ongoing development, consider isolating it (e.g., in a dedicated snapshot profile) and plan to switch to a released version before this POM is used in CI or production pipelines.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread pom.xml Outdated
a-oren added 2 commits June 7, 2026 18:39
Replace SNAPSHOT version with the published release now that
v2.0.8 has been released to Maven Central.

Implements TC-4693

Assisted-by: Claude Code
@a-oren
a-oren requested review from Strum355 and ruromero June 10, 2026 07:58
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@30190c1). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage        ?   68.22%           
  Complexity      ?      987           
=======================================
  Files           ?       65           
  Lines           ?     4201           
  Branches        ?      733           
=======================================
  Hits            ?     2866           
  Misses          ?     1002           
  Partials        ?      333           
Flag Coverage Δ
integration-tests 68.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a-oren
a-oren merged commit 0cce5c0 into guacsec:main Jun 10, 2026
87 of 88 checks passed
@a-oren
a-oren deleted the TC-4693 branch June 10, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants