Skip to content

Commit 09a636b

Browse files
Strum355claude
Strum355
and
claude
committed
fix(yarn-berry): identify workspace member as root in dependency tree
The `#isRoot` method in `Yarn_berry_processor` only matched the workspace root package (`@workspace:.`), causing workspace member analysis to fail to find the member's dependency subtree. Changed to match by manifest name prefix so members like `member-a@workspace:packages/member-a` are correctly identified as the root when analyzing from a workspace member's manifest. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 1684e79 commit 09a636b

9 files changed

Lines changed: 192 additions & 1 deletion

File tree

‎src/providers/processors/yarn_berry_processor.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export default class Yarn_berry_processor extends Yarn_processor {
8080
if (!name) {
8181
return false;
8282
}
83-
return name.endsWith("@workspace:.");
83+
return name.startsWith(`${this._manifest.name}@workspace:`);
8484
}
8585

8686
/**

‎test/providers/javascript.test.js‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,32 @@ suite('testing the javascript-npm data provider', async () => {
106106

107107
});
108108

109+
[
110+
{ providerName: 'yarn-berry', testCase: 'workspace_member' },
111+
].forEach(({ providerName, testCase }) => {
112+
test(`verify workspace member data for ${providerName} - stack analysis`, async () => {
113+
let expectedSbom = fs.readFileSync(`test/providers/tst_manifests/${providerName}/${testCase}/stack_expected_sbom.json`).toString();
114+
let listing = fs.readFileSync(`test/providers/tst_manifests/${providerName}/${testCase}/listing_stack.json`).toString();
115+
116+
const provider = await createMockProvider(providerName, listing);
117+
const manifestPath = `test/providers/tst_manifests/${providerName}/${testCase}/packages/member-a/package.json`;
118+
let providedDataForStack = provider.provideStack(manifestPath);
119+
120+
compareSboms(providedDataForStack.content, expectedSbom);
121+
}).timeout(process.env.GITHUB_ACTIONS ? 30000 : 10000);
122+
123+
test(`verify workspace member data for ${providerName} - component analysis`, async () => {
124+
let expectedSbom = fs.readFileSync(`test/providers/tst_manifests/${providerName}/${testCase}/component_expected_sbom.json`).toString();
125+
let listing = fs.readFileSync(`test/providers/tst_manifests/${providerName}/${testCase}/listing_component.json`).toString();
126+
127+
const provider = await createMockProvider(providerName, listing);
128+
const manifestPath = `test/providers/tst_manifests/${providerName}/${testCase}/packages/member-a/package.json`;
129+
let providedDataForComponent = provider.provideComponent(manifestPath);
130+
131+
compareSboms(providedDataForComponent.content, expectedSbom);
132+
}).timeout(process.env.GITHUB_ACTIONS ? 15000 : 10000);
133+
});
134+
109135
test('loads a valid manifest with ignored dependencies', () => {
110136
const testCase = 'package_json_deps_with_exhortignore_object';
111137
const manifestPath = `test/providers/tst_manifests/npm/${testCase}/package.json`;

‎test/providers/tst_manifests/yarn-berry/workspace_member/component_expected_sbom.json‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
{
2+
"bomFormat": "CycloneDX",
3+
"specVersion": "1.4",
4+
"version": 1,
5+
"metadata": {
6+
"timestamp": "2023-08-07T00:00:00.000Z",
7+
"component": {
8+
"name": "member-a",
9+
"version": "1.0.0",
10+
"purl": "pkg:npm/member-a@1.0.0",
11+
"type": "application",
12+
"bom-ref": "pkg:npm/member-a@1.0.0"
13+
}
14+
},
15+
"components": [
16+
{
17+
"name": "axios",
18+
"version": "0.21.1",
19+
"purl": "pkg:npm/axios@0.21.1",
20+
"type": "library",
21+
"bom-ref": "pkg:npm/axios@0.21.1"
22+
}
23+
],
24+
"dependencies": [
25+
{
26+
"ref": "pkg:npm/member-a@1.0.0",
27+
"dependsOn": [
28+
"pkg:npm/axios@0.21.1"
29+
]
30+
},
31+
{
32+
"ref": "pkg:npm/axios@0.21.1",
33+
"dependsOn": []
34+
}
35+
]
36+
}

‎test/providers/tst_manifests/yarn-berry/workspace_member/listing_component.json‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
{
2+
"value": "axios@npm:0.21.1",
3+
"children": {
4+
"Version": "0.21.1"
5+
}
6+
}
7+
{
8+
"value": "follow-redirects@npm:1.15.6",
9+
"children": {
10+
"Version": "1.15.6"
11+
}
12+
}
13+
{
14+
"value": "test-workspace-root@workspace:.",
15+
"children": {
16+
"Version": "0.0.0"
17+
}
18+
}
19+
{
20+
"value": "member-a@workspace:packages/member-a",
21+
"children": {
22+
"Version": "1.0.0"
23+
}
24+
}

‎test/providers/tst_manifests/yarn-berry/workspace_member/listing_stack.json‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
{
2+
"value": "axios@npm:0.21.1",
3+
"children": {
4+
"Version": "0.21.1",
5+
"Dependencies": [
6+
{
7+
"descriptor": "follow-redirects@npm:^1.14.0",
8+
"locator": "follow-redirects@npm:1.15.6"
9+
}
10+
]
11+
}
12+
}
13+
{
14+
"value": "follow-redirects@npm:1.15.6",
15+
"children": {
16+
"Version": "1.15.6"
17+
}
18+
}
19+
{
20+
"value": "test-workspace-root@workspace:.",
21+
"children": {
22+
"Version": "0.0.0",
23+
"Dependencies": [
24+
{
25+
"descriptor": "member-a@workspace:packages/member-a",
26+
"locator": "member-a@workspace:packages/member-a"
27+
}
28+
]
29+
}
30+
}
31+
{
32+
"value": "member-a@workspace:packages/member-a",
33+
"children": {
34+
"Version": "1.0.0",
35+
"Dependencies": [
36+
{
37+
"descriptor": "axios@npm:^0.21.1",
38+
"locator": "axios@npm:0.21.1"
39+
}
40+
]
41+
}
42+
}

‎test/providers/tst_manifests/yarn-berry/workspace_member/package.json‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"name": "test-workspace-root",
3+
"private": true,
4+
"workspaces": ["packages/*"]
5+
}

‎test/providers/tst_manifests/yarn-berry/workspace_member/packages/member-a/package.json‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"name": "member-a",
3+
"version": "1.0.0",
4+
"dependencies": {
5+
"axios": "0.21.1"
6+
}
7+
}

‎test/providers/tst_manifests/yarn-berry/workspace_member/stack_expected_sbom.json‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
{
2+
"bomFormat": "CycloneDX",
3+
"specVersion": "1.4",
4+
"version": 1,
5+
"metadata": {
6+
"timestamp": "2023-08-07T00:00:00.000Z",
7+
"component": {
8+
"name": "member-a",
9+
"version": "1.0.0",
10+
"purl": "pkg:npm/member-a@1.0.0",
11+
"type": "application",
12+
"bom-ref": "pkg:npm/member-a@1.0.0"
13+
}
14+
},
15+
"components": [
16+
{
17+
"name": "axios",
18+
"version": "0.21.1",
19+
"purl": "pkg:npm/axios@0.21.1",
20+
"type": "library",
21+
"bom-ref": "pkg:npm/axios@0.21.1"
22+
},
23+
{
24+
"name": "follow-redirects",
25+
"version": "1.15.6",
26+
"purl": "pkg:npm/follow-redirects@1.15.6",
27+
"type": "library",
28+
"bom-ref": "pkg:npm/follow-redirects@1.15.6"
29+
}
30+
],
31+
"dependencies": [
32+
{
33+
"ref": "pkg:npm/member-a@1.0.0",
34+
"dependsOn": [
35+
"pkg:npm/axios@0.21.1"
36+
]
37+
},
38+
{
39+
"ref": "pkg:npm/axios@0.21.1",
40+
"dependsOn": [
41+
"pkg:npm/follow-redirects@1.15.6"
42+
]
43+
},
44+
{
45+
"ref": "pkg:npm/follow-redirects@1.15.6",
46+
"dependsOn": []
47+
}
48+
]
49+
}

‎test/providers/tst_manifests/yarn-berry/workspace_member/yarn.lock‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
__metadata:
2+
version: 8

0 commit comments

Comments
 (0)