refactor: replace resolveMavenBinary with shared resolveBinary

Extract a reusable resolveBinary(globalBinary, localWrapper, startDir,
opts) into tools.js and use it from discoverMavenModules, eliminating
the one-off resolveMavenBinary function that duplicated selectToolBinary
logic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Strum355

src/providers/java_maven.js

@@ -7,7 +7,7 @@ import { XMLParser } from 'fast-xml-parser'
 
 import { getLicense } from '../license/license_utils.js'
 import Sbom from '../sbom.js'
-import { getCustom, getCustomPath, getWrapperPreference, invokeCommand, traverseForWrapper } from '../tools.js'
+import { getCustom, invokeCommand, resolveBinary } from '../tools.js'
 import { filterManifestPathsByDiscoveryIgnore, resolveWorkspaceDiscoveryIgnore } from '../workspace.js'
 
 import Base_java, { ecosystem_maven } from "./base_java.js";
@@ -315,25 +315,6 @@ const DEFAULT_MAVEN_DISCOVERY_IGNORE = [
 	'**/target/**',
 ]
 
-/**
- * Resolve the Maven binary, respecting wrapper preference.
- *
- * @param {string} startDir - Directory from which to start the wrapper search
- * @param {object} [opts={}]
- * @returns {string} Path to the Maven binary
- */
-function resolveMavenBinary(startDir, opts = {}) {
-	const localWrapper = 'mvnw' + (process.platform === 'win32' ? '.cmd' : '')
-	const useWrapper = getWrapperPreference('mvn', opts)
-	if (useWrapper) {
-		const wrapper = traverseForWrapper(startDir, localWrapper)
-		if (wrapper !== undefined) {
-			return wrapper
-		}
-	}
-	return getCustomPath('mvn', opts)
-}
-
 /**
  * Discover all pom.xml manifest paths in a Maven multi-module project.
  *
@@ -349,7 +330,8 @@ export async function discoverMavenModules(workspaceRoot, opts = {}) {
 		return []
 	}
 
-	const mvnBin = resolveMavenBinary(root, opts)
+	const localWrapper = 'mvnw' + (process.platform === 'win32' ? '.cmd' : '')
+	const mvnBin = resolveBinary('mvn', localWrapper, root, opts)
 	const visited = new Set()
 	const manifestPaths = [rootPom]
 

src/tools.js

@@ -178,6 +178,25 @@ export function traverseForWrapper(startDir, wrapperName, repoRoot = undefined)
 	}
 }
 
+/**
+ * Resolve a build-tool binary, preferring a wrapper when configured.
+ *
+ * @param {string} globalBinary - Global binary name (e.g. `mvn`, `gradle`)
+ * @param {string} localWrapper - Wrapper filename (e.g. `mvnw`, `gradlew.bat`)
+ * @param {string} startDir - Directory from which to start the wrapper search
+ * @param {import('./index.js').Options} [opts={}]
+ * @returns {string} Path to the resolved binary
+ */
+export function resolveBinary(globalBinary, localWrapper, startDir, opts = {}) {
+	if (getWrapperPreference(globalBinary, opts)) {
+		const wrapper = traverseForWrapper(startDir, localWrapper)
+		if (wrapper !== undefined) {
+			return wrapper
+		}
+	}
+	return getCustomPath(globalBinary, opts)
+}
+
 /** this method invokes command string in a process in a synchronous way.
  * @param {string} bin - the command to be invoked
  * @param {Array<string>} args - the args to pass to the binary