fix(pnpm): select correct workspace member from pnpm ls array#484
Merged
Conversation
When pnpm ls --json runs from a workspace root, it returns an array with one entry per workspace package. Previously, _buildDependencyTree always selected tree[0], which is typically the workspace root — not the member being analyzed. This caused both component and stack analysis to return 0 dependencies for workspace members. Now finds the array element matching the manifest name before falling back to tree[0]. Implements TC-4180 Assisted-by: Claude Code
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pnpm ls without -r only returns the workspace root entry, omitting workspace members entirely. Adding -r includes all workspace packages in the output array. Test fixtures regenerated from actual pnpm ls output (follow-redirects resolved to 1.16.0). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use the larger timeout value unconditionally instead of branching on the CI environment variable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ruromero
previously approved these changes
Apr 23, 2026
Signed-off-by: Noah S-C <nsantsch@redhat.com>
ruromero
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm ls --jsonruns from the workspace root, it returns an array with one entry per workspace package — the override now finds the entry matching the manifest name instead of blindly takingtree[0]Implements TC-4180
Test plan
🤖 Generated with Claude Code