Skip to content

fix(e2e): add missing authentication background to feature files added in #1149 - #1174

Open
chetna14manku wants to merge 1 commit into
guacsec:mainfrom
chetna14manku:update-pr-1149
Open

fix(e2e): add missing authentication background to feature files added in #1149#1174
chetna14manku wants to merge 1 commit into
guacsec:mainfrom
chetna14manku:update-pr-1149

Conversation

@chetna14manku

@chetna14manku chetna14manku commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Add Background: Authentication step to page-title and search feature files to ensure tests pass in auth-required environments.

Summary

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation
  • Other (describe below)

Testing

  • All tests pass (npm test)
  • No lint errors (npm run lint)
  • No type errors (TypeScript compiles cleanly)
  • New/changed UI behavior visually verified in browser
  • Mock data updated if API types changed

Screenshots

Summary by Sourcery

Add authentication background to relevant UI e2e feature files so they run correctly in environments requiring user authentication.

Bug Fixes:

  • Ensure page-title e2e feature scenarios authenticate the user before navigation in auth-required environments.
  • Ensure search page e2e feature scenarios authenticate the user before navigation in auth-required environments.

Tests:

  • Update page-title and search e2e feature files to include a shared authentication background step.

Add Background: Authentication step to page-title and search feature
files to ensure tests pass in auth-required environments.
@sourcery-ai

sourcery-ai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates two E2E UI feature files to include an authentication background so that all scenarios run in authenticated contexts, matching expectations in auth-required environments.

File-Level Changes

Change Details Files
Ensure page-title E2E scenarios run with an authenticated user context.
  • Add a Background section named Authentication to the page-title feature file.
  • Define a Given step that authenticates the user before all scenarios in the feature.
  • Preserve existing page-title scenarios and comments while making authentication a shared precondition.
e2e/tests/ui/features/@page-title/verify-page-title.feature
Ensure search E2E scenarios run with an authenticated user context.
  • Add a Background section named Authentication to the search feature file.
  • Define a Given step that authenticates the user before all search-related scenarios.
  • Keep existing search feature scenarios intact while enforcing authentication as a common setup step.
e2e/tests/ui/features/@search/search.feature

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.03%. Comparing base (ed87429) to head (6254d2a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1174   +/-   ##
=======================================
  Coverage   54.03%   54.03%           
=======================================
  Files         269      269           
  Lines        5904     5904           
  Branches     1849     1849           
=======================================
  Hits         3190     3190           
  Misses       2419     2419           
  Partials      295      295           
Flag Coverage Δ
unit 6.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant