Remove unnecessary transactiontraits

Signed-off-by: mrrajan <86094767+mrrajan@users.noreply.github.com.>

Author: mrrajan

modules/ingestor/src/graph/sbom/common/expanded_license.rs

@@ -28,10 +28,7 @@ use uuid::Uuid;
 ///
 /// Both use the same core logic (expand_license_expression_with_mappings + md5 hash
 /// matching) but optimize for their different use cases.
-pub async fn populate_expanded_license<C>(sbom_id: Uuid, db: &C) -> Result<(), DbErr>
-where
-    C: ConnectionTrait,
-{
+pub async fn populate_expanded_license(sbom_id: Uuid, db: &impl ConnectionTrait) -> Result<(), DbErr> {
     // Step 1: Insert into expanded_license dictionary
     db.execute(Statement::from_sql_and_values(
         db.get_database_backend(),

modules/ingestor/src/graph/sbom/cyclonedx.rs

@@ -21,7 +21,7 @@ use sbom_walker::{
     model::sbom::serde_cyclonedx::Sbom,
     report::{ReportSink, check},
 };
-use sea_orm::{ConnectionTrait, TransactionTrait};
+use sea_orm::ConnectionTrait;
 use serde_cyclonedx::cyclonedx::v_1_6::{
     Component, ComponentEvidenceIdentity, CycloneDx, LicenseChoiceUrl, OrganizationalContact,
 };
@@ -138,15 +138,12 @@ impl<'a> From<Information<'a>> for SbomInformation {
 
 impl SbomContext {
     #[instrument(skip(connection, sbom, warnings), err(level=tracing::Level::INFO))]
-    pub async fn ingest_cyclonedx<C>(
+    pub async fn ingest_cyclonedx(
         &self,
         mut sbom: Box<CycloneDx>,
         warnings: &dyn ReportSink,
-        connection: &C,
-    ) -> Result<(), Error>
-    where
-        C: ConnectionTrait + TransactionTrait,
-    {
+        connection: &impl ConnectionTrait,
+    ) -> Result<(), Error> {
         // pre-flight checks
 
         check::serde_cyclonedx::all(warnings, &Sbom::V1_6(Cow::Borrowed(&sbom)));
@@ -288,10 +285,7 @@ impl<'a> Creator<'a> {
     }
 
     #[instrument(skip(self, db, processors), err(level=tracing::Level::INFO))]
-    pub async fn create<C>(self, db: &C, processors: &mut [Box<dyn Processor>]) -> Result<(), Error>
-    where
-        C: ConnectionTrait + TransactionTrait,
-    {
+    pub async fn create(self, db: &impl ConnectionTrait, processors: &mut [Box<dyn Processor>]) -> Result<(), Error> {
         let mut creator = ComponentCreator::new(self.sbom_id, self.components.len());
 
         for comp in self.components {
@@ -578,10 +572,7 @@ impl ComponentCreator {
     // order matters to prevent cross-table deadlocks when running
     // concurrent SBOM ingestions. All SBOM loaders must use the same
     // table insertion order.
-    async fn create<C>(self, db: &C) -> Result<(), Error>
-    where
-        C: ConnectionTrait + TransactionTrait,
-    {
+    async fn create(self, db: &impl ConnectionTrait) -> Result<(), Error> {
         self.licenses.create(db).await?;
         self.purls.create(db).await?;
         self.cpes.create(db).await?;

modules/ingestor/src/graph/sbom/spdx.rs

@@ -16,7 +16,7 @@ use crate::{
     service::Error,
 };
 use sbom_walker::report::{ReportSink, check};
-use sea_orm::{ConnectionTrait, TransactionTrait};
+use sea_orm::ConnectionTrait;
 use spdx_rs::models::{RelationshipType, SPDX};
 use std::collections::HashSet;
 use std::str::FromStr;
@@ -103,15 +103,12 @@ impl<'a> From<Information<'a>> for SbomInformation {
 
 impl SbomContext {
     #[instrument(skip(db, sbom_data, warnings), ret(level=tracing::Level::DEBUG))]
-    pub async fn ingest_spdx<C>(
+    pub async fn ingest_spdx(
         &self,
         sbom_data: SPDX,
         warnings: &dyn ReportSink,
-        db: &C,
-    ) -> Result<(), Error>
-    where
-        C: ConnectionTrait + TransactionTrait,
-    {
+        db: &impl ConnectionTrait,
+    ) -> Result<(), Error> {
         // pre-flight checks
 
         check::spdx::all(warnings, &sbom_data);