perf(thanks-command): Simplify OS-specific URL opening logic

- Refactor the URL opening logic to use a match expression for clarity.
- Ensure compatibility across macOS, Windows, and Linux platforms.
- Improve code maintainability by reducing conditional statements.

Author: ityaozm@gmail.com

app/Commands/ConfigCommand.php

@@ -30,14 +30,9 @@
 
 final class ConfigCommand extends Command
 {
-    /** @var list<string> */
-    public const ACTIONS = ['set', 'get', 'unset', 'reset', 'list', 'edit'];
-
-    /** @var list<string> */
-    protected const WINDOWS_EDITORS = ['notepad'];
-
-    /** @var list<string> */
-    protected const UNIX_EDITORS = ['editor', 'vim', 'vi', 'nano', 'pico', 'ed'];
+    private const ACTIONS = ['set', 'get', 'unset', 'reset', 'list', 'edit'];
+    private const UNIX_EDITORS = ['editor', 'vim', 'vi', 'nano', 'pico', 'ed'];
+    private const WINDOWS_EDITORS = ['notepad'];
 
     /** @noinspection ClassOverridesFieldOfSuperClassInspection */
     protected $signature = 'config';
@@ -53,25 +48,14 @@ public function __construct()
     }
 
     /**
+     * @throws \Illuminate\Contracts\Filesystem\FileNotFoundException
      * @throws \JsonException
      * @throws \Psr\Container\ContainerExceptionInterface
      * @throws \Psr\Container\NotFoundExceptionInterface
      */
     public function handle(ExecutableFinder $executableFinder): int
     {
-        /** @var string $file */
-        $file = value(function () {
-            if ($file = $this->option('file')) {
-                return $file;
-            }
-
-            if ($this->option('global')) {
-                return ConfigManager::globalPath();
-            }
-
-            return ConfigManager::localPath();
-        });
-
+        $file = $this->configFile();
         $this->output->note("The config file($file) is being operated.");
         file_exists($file) or $this->configManager->putFile($file);
         $this->configManager->replaceFrom($file);
@@ -176,6 +160,11 @@ public function schedule(Schedule $schedule): void
         // $schedule->command(static::class)->everyMinute();
     }
 
+    public static function hydratedActions(): string
+    {
+        return implode(', ', self::ACTIONS);
+    }
+
     /**
      * {@inheritDoc}
      *
@@ -185,7 +174,7 @@ public function schedule(Schedule $schedule): void
     protected function configure(): void
     {
         $this->setDefinition([
-            new InputArgument('action', InputArgument::REQUIRED, \sprintf('The action(<comment>[%s]</comment>) name', implode(', ', self::ACTIONS))),
+            new InputArgument('action', InputArgument::REQUIRED, \sprintf('The action(<comment>[%s]</comment>) name', self::hydratedActions())),
             new InputArgument('key', InputArgument::OPTIONAL, 'The key of config options'),
             new InputArgument('value', InputArgument::OPTIONAL, 'The value of config options'),
             new InputOption('global', 'g', InputOption::VALUE_NONE, 'Apply to the global config file'),
@@ -250,4 +239,17 @@ private function valueToArg(mixed $value): string
 
         return (string) json_encode($value, \JSON_PRETTY_PRINT | \JSON_UNESCAPED_UNICODE);
     }
+
+    private function configFile(): string
+    {
+        if ($file = $this->option('file')) {
+            return $file;
+        }
+
+        if ($this->option('global')) {
+            return ConfigManager::globalPath();
+        }
+
+        return ConfigManager::localPath();
+    }
 }

app/Commands/ThanksCommand.php

@@ -29,9 +29,11 @@ public function handle(): void
         $wantsToSupport = $this->ask('Can you quickly <options=bold>star our GitHub repository</>? 🙏🏻', 'yes');
 
         if (str($wantsToSupport)->trim()->is(['yes', 'y'])) {
-            \PHP_OS_FAMILY === 'Darwin' and exec('open https://github.com/guanguans/ai-commit');
-            \PHP_OS_FAMILY === 'Windows' and exec('start https://github.com/guanguans/ai-commit');
-            \PHP_OS_FAMILY === 'Linux' and exec('xdg-open https://github.com/guanguans/ai-commit');
+            exec(match (\PHP_OS_FAMILY) {
+                'Darwin' => 'open https://github.com/guanguans/ai-commit',
+                'Windows' => 'start https://github.com/guanguans/ai-commit',
+                default => 'xdg-open https://github.com/guanguans/ai-commit',
+            });
         }
 
         $this->output->writeln([

app/Exceptions/UnsupportedConfigActionException.php

@@ -20,7 +20,7 @@ final class UnsupportedConfigActionException extends InvalidArgumentException
     public static function make(string $action, int $code = 0, ?\Throwable $previous = null): self
     {
         return new self(
-            \sprintf("The action [$action] is not supported, that must be one of [%s].", implode(', ', ConfigCommand::ACTIONS)),
+            \sprintf("The action [$action] is not supported, that must be one of [%s].", ConfigCommand::hydratedActions()),
             $code,
             $previous
         );