Add newsletter data to FAPI front press#28814
Open
georgerichmond wants to merge 7 commits into
Open
Conversation
georgerichmond
force-pushed
the
newsletter-signup-cards-in-highlights
branch
from
281db4e to
6118c5f
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds newsletter signup metadata into the facia-press “pressed” JSON so downstream consumers (e.g. rendering) can access PressedProperties.newsletterData when content is tagged for newsletter signup.
Changes:
- Add
newsletterData: Option[NewsletterData]toPressedPropertiesand JSON formatting support. - Enrich pressed front content in
FapiFrontPressusing a newNewsletterEnrichmenthelper plus wiringNewsletterServiceinto facia-press. - Add unit tests for
NewsletterService.getNewsletterDataFromTagsand newsletter enrichment.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| facia-press/test/frontpress/NewsletterEnrichmentTest.scala | Adds tests for enriching pressed content with newsletter data. |
| facia-press/app/frontpress/FapiFrontPress.scala | Wires NewsletterService into front press and enriches pressed content with newsletter data. |
| facia-press/app/AppLoader.scala | Wires newsletter API/agent/service and lifecycle into facia-press. |
| common/test/services/NewsletterServiceTest.scala | Adds unit tests for NewsletterService.getNewsletterDataFromTags. |
| common/app/services/NewsletterService.scala | Adds getNewsletterDataFromTags helper for tag-based lookup. |
| common/app/model/PressedProperties.scala | Adds newsletterData field to pressed properties. |
| common/app/model/Formats.scala | Adds JSON OFormat for NewsletterData to support serializing pressed properties. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…trationCircle field
georgerichmond
force-pushed
the
newsletter-signup-cards-in-highlights
branch
from
63f764a to
9947513
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
This PR adds newsletter signup metadata into the facia-press “pressed” JSON so downstream consumers (e.g. rendering) can access PressedProperties.newsletterData when content is tagged for newsletter signup.
What does this change?
Add newsletterData: Option[NewsletterData] to PressedProperties and JSON formatting support.
Enrich pressed front content in FapiFrontPress using a new NewsletterEnrichment helper plus wiring NewsletterService into facia-press.
Add unit tests for NewsletterService.getNewsletterDataFromTags and newsletter enrichment.
Screenshots
Checklist
data/databasefiles generated by tests are committed with this PR (the tests will fail in CI if you've forgotten to do this)