Skip to content

Release v1.18.1#4044

Closed
tig wants to merge 19 commits into
tui-cs:v1_releasefrom
tig:v1_18_1
Closed

Release v1.18.1#4044
tig wants to merge 19 commits into
tui-cs:v1_releasefrom
tig:v1_18_1

Conversation

@tig

@tig tig commented Apr 24, 2025

Copy link
Copy Markdown
Member

No description provided.

BDisp and others added 19 commits August 12, 2024 06:44
…ui-cs#3658)

* V1 Fixes tui-cs#3541. Checking if clipboard is available on windows.

* Fix nuget packages with vulnerabilities.
…xception-fix

V1 - Fixes tui-cs#3740. Disabled MenuItem triggers exception.
…eview-fix

Fixes tui-cs#3752. Tracking Windows Terminal Preview Issue - App size is corrupted
…n) (tui-cs#4036)

* Revert "Fixes tui-cs#3752. Tracking Windows Terminal Preview Issue - App size is corrupted"

This reverts commit 486f129.

* Fix console restore on non-Windows Terminal

* Remove unsupported net7.0

* Fix Package 'SixLabors.ImageSharp' 3.1.5 has a known high severity vulnerability, GHSA-2cmq-823j-5qj8

* Fix punctuation at the end of the messages doesn't match up. The expected trailing punctuation sequence is: ...

* Fix referenced assembly 'UICatalog, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

* Fix naming rule violation
@tig tig requested a review from Copilot April 24, 2025 12:08
@tig tig closed this Apr 24, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Windows console driver to support both the Windows Terminal and traditional console modes by introducing a new screen buffer handle and conditionally using it throughout the driver.

  • Introduces a new field "screenBuffer" to track the active console screen buffer when not in Windows Terminal.
  • Updates several functions to use a conditional handle (either OutputHandle or screenBuffer) based on the IsWindowsTerminal property, ensuring that operations like writing output, setting cursor positions, and resizing the console window work correctly in both environments.
Files not reviewed (6)
  • ReactiveExample/ReactiveExample.csproj: Language not supported
  • Terminal.Gui/Resources/Strings.ja-JP.resx: Language not supported
  • Terminal.Gui/Resources/Strings.pt-PT.resx: Language not supported
  • Terminal.Gui/Terminal.Gui.csproj: Language not supported
  • UICatalog/UICatalog.csproj: Language not supported
  • UnitTests/UnitTests.csproj: Language not supported

Comment thread Terminal.Gui/ConsoleDrivers/WindowsDriver.cs
Comment thread Terminal.Gui/ConsoleDrivers/WindowsDriver.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants