Handle flag cases of slurm job state#120
Open
tokenrove wants to merge 2 commits intoguilbaults:mainfrom
Open
Conversation
We had a user report a 500 error, caused by indexing off the end of the status list in this code. When I took a look at the database, I saw a job state value of 1024, which prompted me to check slurm's source for how state values are handled. See the following files in slurm's source: src/common/slurm_protocol_defs.c slurm/slurm.h This code follows the inconsistent order in which slurm's own code handles these flags, all of which seem to preempt the JOB_STATE_BASE values. Note that there are some flags defined which aren't handled; presumbly the base states take priority in these cases, in terms of reporting a single string to summarize the state.
It's not clear to me that there's a way to write this using `choices` that can express everything going on with slurm job state, so we provide get_state_display() ourselves. Keep StatesJob, however, as its constants are used elsewhere in the code (somewhat validly, though ideally we'd mask such tests by 255).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a user report a 500 error, caused by indexing off the end of the status list in this code. When I took a look at the database, I saw a job state value of 1024, which prompted me to check slurm's source for how state values are handled.
See the following files in slurm's source:
src/common/slurm_protocol_defs.c
slurm/slurm.h
This code follows the inconsistent order in which slurm's own code handles these flags, all of which seem to preempt the JOB_STATE_BASE values. Note that there are some flags defined which aren't handled; presumbly the base states take priority in these cases, in terms of reporting a single string to summarize the state.