fix: update workflow to properly publish helm chart

Author: gurghet

.github/workflows/release.yaml

@@ -4,9 +4,6 @@ on:
   push:
     branches:
       - master
-  pull_request:
-    branches:
-      - master
 
 env:
   REGISTRY: ghcr.io
@@ -15,32 +12,26 @@ env:
 jobs:
   release:
     runs-on: ubuntu-latest
-    if: github.event_name != 'pull_request'
     permissions:
       contents: write
-      issues: write
-      pull-requests: write
       packages: write
-    
     outputs:
       new_release_published: ${{ steps.semantic.outputs.new_release_published }}
       new_release_version: ${{ steps.semantic.outputs.new_release_version }}
-    
     steps:
       - name: Checkout
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-          
+
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v3
         with:
-          node-version: 'lts/*'
-          
-      - name: Install semantic-release
-        run: |
-          npm install -g semantic-release @semantic-release/commit-analyzer @semantic-release/release-notes-generator @semantic-release/github
-          
+          node-version: "lts/*"
+
+      - name: Install dependencies
+        run: npm install -g semantic-release @semantic-release/git @semantic-release/github
+
       - name: Create Release
         id: semantic
         env:
@@ -54,9 +45,8 @@ jobs:
     permissions:
       contents: read
       packages: write
-
     steps:
-      - name: Checkout repository
+      - name: Checkout
         uses: actions/checkout@v4
 
       - name: Set up Docker Buildx
@@ -69,130 +59,61 @@ jobs:
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Extract metadata for Docker
-        id: meta
-        uses: docker/metadata-action@v5
-        with:
-          images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
-          tags: |
-            type=semver,pattern={{version}},value=v${{ needs.release.outputs.new_release_version }}
-            type=semver,pattern={{major}}.{{minor}},value=v${{ needs.release.outputs.new_release_version }}
-            type=raw,value=latest
-
       - name: Build and push Docker image
         uses: docker/build-push-action@v5
         with:
           context: .
           push: true
-          tags: ${{ steps.meta.outputs.tags }}
-          labels: ${{ steps.meta.outputs.labels }}
+          tags: |
+            ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest
+            ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:v${{ needs.release.outputs.new_release_version }}
           cache-from: type=gha
           cache-to: type=gha,mode=max
 
-  release-chart:
+  publish-helm:
     needs: release
     if: needs.release.outputs.new_release_published == 'true'
     runs-on: ubuntu-latest
     permissions:
       contents: write
-    
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
 
       - name: Configure Git
         run: |
-          git config user.name "$GITHUB_ACTOR"
-          git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
-      
+          git config user.name "${{ github.actor }}"
+          git config user.email "${{ github.actor }}@users.noreply.github.com"
+
       - name: Install Helm
         uses: azure/setup-helm@v3
         with:
           version: v3.12.1
 
+      - name: Update chart version
+        run: |
+          yq e -i '.version = "${{ needs.release.outputs.new_release_version }}"' charts/github-deploy-key-operator/Chart.yaml
+          yq e -i '.appVersion = "${{ needs.release.outputs.new_release_version }}"' charts/github-deploy-key-operator/Chart.yaml
+
       - name: Package Helm chart
         run: |
           mkdir -p .cr-release-packages
-          helm package charts/github-deploy-key-operator --version ${{ needs.release.outputs.new_release_version }} --destination .cr-release-packages
+          helm package charts/github-deploy-key-operator --version ${{ needs.release.outputs.new_release_version }} -d .cr-release-packages
 
-      - name: Upload Helm chart
-        uses: actions/upload-artifact@v3
-        with:
-          name: helm-chart
-          path: .cr-release-packages/*.tgz
-
-      - name: Download previous charts
+      - name: Checkout gh-pages branch
         run: |
+          git fetch origin gh-pages || true
           git checkout gh-pages || git checkout --orphan gh-pages
           git rm -rf . || true
-          git clean -fxd
-          mkdir -p charts
-          
-      - name: Download chart artifact
-        uses: actions/download-artifact@v3
-        with:
-          name: helm-chart
-          path: charts
+          git clean -fxd || true
 
-      - name: Generate Helm repo index
+      - name: Update Helm repository
         run: |
+          mkdir -p charts
+          mv .cr-release-packages/* charts/
           helm repo index charts/
-          cp charts/index.yaml index.yaml
-
-      - name: Push to gh-pages
-        run: |
           git add charts/
-          git add index.yaml
-          git commit -m "chore: publish helm chart ${{ needs.release.outputs.new_release_version }}"
-          git push origin gh-pages -f
-
-  publish-chart:
-    needs: release-chart
-    if: needs.release.outputs.new_release_published == 'true'
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write
-      pages: write
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Configure Git
-        run: |
-          git config user.name "$GITHUB_ACTOR"
-          git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
-
-      - name: Install Helm
-        uses: azure/setup-helm@v3
-
-      - name: Update chart version
-        env:
-          VERSION: ${{ needs.release.outputs.new_release_version }}
-        run: |
-          yq e -i '.version = env(VERSION)' charts/github-deploy-key-operator/Chart.yaml
-          yq e -i '.appVersion = env(VERSION)' charts/github-deploy-key-operator/Chart.yaml
-
-      - name: Package Helm chart
-        run: |
-          helm package charts/github-deploy-key-operator
-
-      - name: Setup GitHub Pages
-        uses: actions/configure-pages@v4
-
-      - name: Upload GitHub Pages artifact
-        uses: actions/upload-pages-artifact@v3
-        with:
-          path: '.'
-
-      - name: Deploy GitHub Pages
-        uses: actions/deploy-pages@v4
-
-      - name: Upload chart to release
-        uses: softprops/action-gh-release@v1
-        with:
-          tag_name: v${{ needs.release.outputs.new_release_version }}
-          files: github-deploy-key-operator-*.tgz
-          generate_release_notes: true
+          git commit -m "chore: publish helm chart v${{ needs.release.outputs.new_release_version }}"
+          git push origin gh-pages