possible fix for GC tests

gustavopsantos · gustavopsantos · commit c62b28133a47 · 2026-03-09T23:21:06.000-03:00
diff --git a/Assets/Reflex.EditModeTests/GarbageCollectionTests.cs b/Assets/Reflex.EditModeTests/GarbageCollectionTests.cs
@@ -1,6 +1,7 @@
 ﻿using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading.Tasks;
 using FluentAssertions;
 using NUnit.Framework;
 using Reflex.Core;
@@ -17,11 +18,14 @@ private class Service
         {
         }
 
-        public static void ForceGarbageCollection()
+        public static async Task ForceGarbageCollection()
         {
             Resources.UnloadUnusedAssets();
             GC.Collect();
             GC.WaitForPendingFinalizers();
+            await Task.Yield();
+            GC.Collect();
+            GC.WaitForPendingFinalizers();
         }
         
         [OneTimeSetUp]
@@ -34,7 +38,7 @@ public void Setup()
         }
 
         [Test, Retry(3)]
-        public void Singleton_ShouldBeFinalized_WhenOwnerIsDisposed()
+        public async Task Singleton_ShouldBeFinalized_WhenOwnerIsDisposed()
         {
             var references = new List<WeakReference>();
 
@@ -47,12 +51,12 @@ void Act()
             }
 
             Act();
-            ForceGarbageCollection();
+            await ForceGarbageCollection();
             references.Any(r => r.IsAlive).Should().BeFalse();
         }
 
         [Test, Retry(3)]
-        public void DisposedScopedContainer_ShouldHaveNoReferencesToItself_AndShouldBeCollectedAndFinalized()
+        public async Task DisposedScopedContainer_ShouldHaveNoReferencesToItself_AndShouldBeCollectedAndFinalized()
         {
             var references = new List<WeakReference>();
 
@@ -65,12 +69,12 @@ void Act()
             }
 
             Act();
-            ForceGarbageCollection();
+            await ForceGarbageCollection();
             references.Any(r => r.IsAlive).Should().BeFalse();
         }
 
         [Test, Retry(3)]
-        public void Construct_ContainerShouldNotControlConstructedObjectLifeCycle_ByNotKeepingReferenceToIt()
+        public async Task Construct_ContainerShouldNotControlConstructedObjectLifeCycle_ByNotKeepingReferenceToIt()
         {
             var references = new List<WeakReference>();
             var container = new ContainerBuilder().Build();
@@ -82,7 +86,7 @@ void Act()
             }
 
             Act();
-            ForceGarbageCollection();
+            await ForceGarbageCollection();
             references.Any(r => r.IsAlive).Should().BeFalse();
         }
     }
diff --git a/Assets/Reflex.EditModeTests/ScopedTests.cs b/Assets/Reflex.EditModeTests/ScopedTests.cs
@@ -1,5 +1,6 @@
 ﻿using System;
 using System.Collections.Generic;
+using System.Threading.Tasks;
 using FluentAssertions;
 using NUnit.Framework;
 using Reflex.Core;
@@ -94,7 +95,7 @@ public void ScopedFromFactory_ConstructedInstances_ShouldBeDisposed_WithinConstr
         }
         
         [Test, Retry(3)]
-        public void ScopedFromType_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()
+        public async Task ScopedFromType_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()
         {
             WeakReference instanceConstructedByChild;
             WeakReference instanceConstructedByParent;
@@ -110,13 +111,13 @@ void Act()
             }
             
             Act();
-            GarbageCollectionTests.ForceGarbageCollection();
+            await GarbageCollectionTests.ForceGarbageCollection();
             instanceConstructedByChild.IsAlive.Should().BeFalse();
             instanceConstructedByParent.IsAlive.Should().BeTrue();
         }
         
         [Test, Retry(3)]
-        public void ScopedFromFactory_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()
+        public async Task ScopedFromFactory_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()
         {
             WeakReference instanceConstructedByChild;
             WeakReference instanceConstructedByParent;
@@ -132,7 +133,7 @@ void Act()
             }
             
             Act();
-            GarbageCollectionTests.ForceGarbageCollection();
+            await GarbageCollectionTests.ForceGarbageCollection();
             instanceConstructedByChild.IsAlive.Should().BeFalse();
             instanceConstructedByParent.IsAlive.Should().BeTrue();
         }
diff --git a/Assets/Reflex.EditModeTests/TransientTests.cs b/Assets/Reflex.EditModeTests/TransientTests.cs
@@ -1,4 +1,5 @@
 ﻿using System;
+using System.Threading.Tasks;
 using FluentAssertions;
 using NUnit.Framework;
 using Reflex.Core;
@@ -49,7 +50,7 @@ public void TransientFromFactory_ConstructedInstances_ShouldBeDisposed_WithinCon
         }
         
         [Test, Retry(3)]
-        public void TransientFromType_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()
+        public async Task TransientFromType_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()
         {
             WeakReference instanceConstructedByChild;
             WeakReference instanceConstructedByParent;
@@ -65,13 +66,13 @@ void Act()
             }
             
             Act();
-            GarbageCollectionTests.ForceGarbageCollection();
+            await GarbageCollectionTests.ForceGarbageCollection();
             instanceConstructedByChild.IsAlive.Should().BeFalse();
             instanceConstructedByParent.IsAlive.Should().BeTrue();
         }
         
         [Test, Retry(3)]
-        public void TransientFromFactory_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()
+        public async Task TransientFromFactory_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()
         {
             WeakReference instanceConstructedByChild;
             WeakReference instanceConstructedByParent;
@@ -87,7 +88,7 @@ void Act()
             }
             
             Act();
-            GarbageCollectionTests.ForceGarbageCollection();
+            await GarbageCollectionTests.ForceGarbageCollection();
             instanceConstructedByChild.IsAlive.Should().BeFalse();
             instanceConstructedByParent.IsAlive.Should().BeTrue();
         }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.Collections.Generic;`
`3`	`3`	`using System.Linq;`
	`4`	`+using System.Threading.Tasks;`
`4`	`5`	`using FluentAssertions;`
`5`	`6`	`using NUnit.Framework;`
`6`	`7`	`using Reflex.Core;`
`@@ -17,11 +18,14 @@ private class Service`
`17`	`18`	`{`
`18`	`19`	`}`
`19`	`20`
`20`		`- public static void ForceGarbageCollection()`
	`21`	`+ public static async Task ForceGarbageCollection()`
`21`	`22`	`{`
`22`	`23`	`Resources.UnloadUnusedAssets();`
`23`	`24`	`GC.Collect();`
`24`	`25`	`GC.WaitForPendingFinalizers();`
	`26`	`+ await Task.Yield();`
	`27`	`+ GC.Collect();`
	`28`	`+ GC.WaitForPendingFinalizers();`
`25`	`29`	`}`
`26`	`30`
`27`	`31`	`[OneTimeSetUp]`
`@@ -34,7 +38,7 @@ public void Setup()`
`34`	`38`	`}`
`35`	`39`
`36`	`40`	`[Test, Retry(3)]`
`37`		`- public void Singleton_ShouldBeFinalized_WhenOwnerIsDisposed()`
	`41`	`+ public async Task Singleton_ShouldBeFinalized_WhenOwnerIsDisposed()`
`38`	`42`	`{`
`39`	`43`	`var references = new List<WeakReference>();`
`40`	`44`
`@@ -47,12 +51,12 @@ void Act()`
`47`	`51`	`}`
`48`	`52`
`49`	`53`	`Act();`
`50`		`- ForceGarbageCollection();`
	`54`	`+ await ForceGarbageCollection();`
`51`	`55`	`references.Any(r => r.IsAlive).Should().BeFalse();`
`52`	`56`	`}`
`53`	`57`
`54`	`58`	`[Test, Retry(3)]`
`55`		`- public void DisposedScopedContainer_ShouldHaveNoReferencesToItself_AndShouldBeCollectedAndFinalized()`
	`59`	`+ public async Task DisposedScopedContainer_ShouldHaveNoReferencesToItself_AndShouldBeCollectedAndFinalized()`
`56`	`60`	`{`
`57`	`61`	`var references = new List<WeakReference>();`
`58`	`62`
`@@ -65,12 +69,12 @@ void Act()`
`65`	`69`	`}`
`66`	`70`
`67`	`71`	`Act();`
`68`		`- ForceGarbageCollection();`
	`72`	`+ await ForceGarbageCollection();`
`69`	`73`	`references.Any(r => r.IsAlive).Should().BeFalse();`
`70`	`74`	`}`
`71`	`75`
`72`	`76`	`[Test, Retry(3)]`
`73`		`- public void Construct_ContainerShouldNotControlConstructedObjectLifeCycle_ByNotKeepingReferenceToIt()`
	`77`	`+ public async Task Construct_ContainerShouldNotControlConstructedObjectLifeCycle_ByNotKeepingReferenceToIt()`
`74`	`78`	`{`
`75`	`79`	`var references = new List<WeakReference>();`
`76`	`80`	`var container = new ContainerBuilder().Build();`
`@@ -82,7 +86,7 @@ void Act()`
`82`	`86`	`}`
`83`	`87`
`84`	`88`	`Act();`
`85`		`- ForceGarbageCollection();`
	`89`	`+ await ForceGarbageCollection();`
`86`	`90`	`references.Any(r => r.IsAlive).Should().BeFalse();`
`87`	`91`	`}`
`88`	`92`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.Collections.Generic;`
	`3`	`+using System.Threading.Tasks;`
`3`	`4`	`using FluentAssertions;`
`4`	`5`	`using NUnit.Framework;`
`5`	`6`	`using Reflex.Core;`
`@@ -94,7 +95,7 @@ public void ScopedFromFactory_ConstructedInstances_ShouldBeDisposed_WithinConstr`
`94`	`95`	`}`
`95`	`96`
`96`	`97`	`[Test, Retry(3)]`
`97`		`- public void ScopedFromType_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()`
	`98`	`+ public async Task ScopedFromType_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()`
`98`	`99`	`{`
`99`	`100`	`WeakReference instanceConstructedByChild;`
`100`	`101`	`WeakReference instanceConstructedByParent;`
`@@ -110,13 +111,13 @@ void Act()`
`110`	`111`	`}`
`111`	`112`
`112`	`113`	`Act();`
`113`		`- GarbageCollectionTests.ForceGarbageCollection();`
	`114`	`+ await GarbageCollectionTests.ForceGarbageCollection();`
`114`	`115`	`instanceConstructedByChild.IsAlive.Should().BeFalse();`
`115`	`116`	`instanceConstructedByParent.IsAlive.Should().BeTrue();`
`116`	`117`	`}`
`117`	`118`
`118`	`119`	`[Test, Retry(3)]`
`119`		`- public void ScopedFromFactory_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()`
	`120`	`+ public async Task ScopedFromFactory_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()`
`120`	`121`	`{`
`121`	`122`	`WeakReference instanceConstructedByChild;`
`122`	`123`	`WeakReference instanceConstructedByParent;`
`@@ -132,7 +133,7 @@ void Act()`
`132`	`133`	`}`
`133`	`134`
`134`	`135`	`Act();`
`135`		`- GarbageCollectionTests.ForceGarbageCollection();`
	`136`	`+ await GarbageCollectionTests.ForceGarbageCollection();`
`136`	`137`	`instanceConstructedByChild.IsAlive.Should().BeFalse();`
`137`	`138`	`instanceConstructedByParent.IsAlive.Should().BeTrue();`
`138`	`139`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`using System;`
	`2`	`+using System.Threading.Tasks;`
`2`	`3`	`using FluentAssertions;`
`3`	`4`	`using NUnit.Framework;`
`4`	`5`	`using Reflex.Core;`
`@@ -49,7 +50,7 @@ public void TransientFromFactory_ConstructedInstances_ShouldBeDisposed_WithinCon`
`49`	`50`	`}`
`50`	`51`
`51`	`52`	`[Test, Retry(3)]`
`52`		`- public void TransientFromType_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()`
	`53`	`+ public async Task TransientFromType_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()`
`53`	`54`	`{`
`54`	`55`	`WeakReference instanceConstructedByChild;`
`55`	`56`	`WeakReference instanceConstructedByParent;`
`@@ -65,13 +66,13 @@ void Act()`
`65`	`66`	`}`
`66`	`67`
`67`	`68`	`Act();`
`68`		`- GarbageCollectionTests.ForceGarbageCollection();`
	`69`	`+ await GarbageCollectionTests.ForceGarbageCollection();`
`69`	`70`	`instanceConstructedByChild.IsAlive.Should().BeFalse();`
`70`	`71`	`instanceConstructedByParent.IsAlive.Should().BeTrue();`
`71`	`72`	`}`
`72`	`73`
`73`	`74`	`[Test, Retry(3)]`
`74`		`- public void TransientFromFactory_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()`
	`75`	`+ public async Task TransientFromFactory_ConstructedInstances_ShouldBeCollected_WhenConstructingContainerIsDisposed()`
`75`	`76`	`{`
`76`	`77`	`WeakReference instanceConstructedByChild;`
`77`	`78`	`WeakReference instanceConstructedByParent;`
`@@ -87,7 +88,7 @@ void Act()`
`87`	`88`	`}`
`88`	`89`
`89`	`90`	`Act();`
`90`		`- GarbageCollectionTests.ForceGarbageCollection();`
	`91`	`+ await GarbageCollectionTests.ForceGarbageCollection();`
`91`	`92`	`instanceConstructedByChild.IsAlive.Should().BeFalse();`
`92`	`93`	`instanceConstructedByParent.IsAlive.Should().BeTrue();`
`93`	`94`	`}`