Add diagnostics to e2e post-boot hook for CI debugging

SSH hang is fixed but a test still fails. Add verbose logging:
- Verify Xvfb is actually running after launch
- Check lighttpd status before starting GUI
- Log start_gui output to /tmp for inspection
- Print periodic diagnostics during Chromium wait loop
- Show final X display window state
- Remove set -e to prevent silent early exits

Author: guysoft

testing/hooks/post-boot.sh

@@ -1,37 +1,64 @@
 #!/bin/bash
-set -e
 SSH_HOST="${1:-localhost}"
 SSH_PORT="${2:-2222}"
 
 SSH_CMD="sshpass -p raspberry ssh -o StrictHostKeyChecking=no -o ConnectTimeout=10 -p $SSH_PORT pi@$SSH_HOST"
 
-echo "Installing Xvfb and configuring virtual display..."
+echo "Installing Xvfb and x11-apps..."
+$SSH_CMD "sudo apt-get update -qq && sudo DEBIAN_FRONTEND=noninteractive apt-get install -y -qq xvfb x11-apps 2>&1 | tail -5"
 
-# Install xvfb and x11-apps (for xwd screenshot capture)
-$SSH_CMD "sudo apt-get update -qq && sudo DEBIAN_FRONTEND=noninteractive apt-get install -y -qq xvfb x11-apps 2>&1 | tail -3"
-
-# In QEMU virt, logind's seat0 has CanGraphical=no (no real display device),
-# so lightdm won't start an X session. Start Xvfb and the GUI session directly.
 echo "Starting Xvfb virtual display..."
-$SSH_CMD "sudo nohup Xvfb :0 -screen 0 1280x720x24 > /dev/null 2>&1 < /dev/null &"
-sleep 2
+$SSH_CMD "sudo nohup Xvfb :0 -screen 0 1280x720x24 > /tmp/xvfb.log 2>&1 < /dev/null &"
+sleep 3
+
+echo "Verifying Xvfb is running..."
+XVFB_PID=$($SSH_CMD "pgrep -f 'Xvfb :0' || true" 2>/dev/null)
+if [ -z "$XVFB_PID" ]; then
+    echo "  WARNING: Xvfb not running, checking log..."
+    $SSH_CMD "cat /tmp/xvfb.log 2>/dev/null || true" 2>/dev/null
+else
+    echo "  Xvfb running (pid: $XVFB_PID)"
+fi
+
+echo "Checking lighttpd status..."
+$SSH_CMD "systemctl is-active lighttpd 2>/dev/null || true" 2>/dev/null
+$SSH_CMD "curl -s -o /dev/null -w 'HTTP %{http_code}' http://localhost/ || true" 2>/dev/null
+echo ""
 
 echo "Starting GUI session (matchbox + chromium kiosk)..."
-$SSH_CMD "sudo -u pi nohup bash -c 'export DISPLAY=:0; export HOME=/home/pi; /opt/custompios/scripts/start_gui' > /dev/null 2>&1 < /dev/null &"
+$SSH_CMD "sudo -u pi nohup bash -c 'export DISPLAY=:0; export HOME=/home/pi; /opt/custompios/scripts/start_gui' > /tmp/start_gui.log 2>&1 < /dev/null &"
 
-# Wait for Chromium to appear on the display
 echo "Waiting for Chromium to start..."
-for i in $(seq 1 30); do
+for i in $(seq 1 60); do
     PGREP=$($SSH_CMD "pgrep -f 'chromium.*--kiosk' || true" 2>/dev/null)
     if [ -n "$PGREP" ]; then
-        echo "  Chromium running on display (pid: $PGREP)"
+        echo "  Chromium running (pid: $PGREP) after ${i}x5s"
         break
     fi
+    if [ "$((i % 6))" -eq 0 ]; then
+        echo "  ... still waiting (${i}x5s), diagnostics:"
+        $SSH_CMD "pgrep -a Xvfb || echo '  Xvfb: NOT RUNNING'" 2>/dev/null || true
+        $SSH_CMD "pgrep -a matchbox || echo '  matchbox: NOT RUNNING'" 2>/dev/null || true
+        $SSH_CMD "pgrep -a chromium || echo '  chromium: NOT RUNNING'" 2>/dev/null || true
+        $SSH_CMD "tail -5 /tmp/start_gui.log 2>/dev/null || true" 2>/dev/null || true
+    fi
     sleep 5
 done
 
-# Give the page time to render
-echo "  Waiting for page to load..."
+if [ -z "$PGREP" ]; then
+    echo "  WARNING: Chromium did not appear after 300s"
+    echo "  start_gui log:"
+    $SSH_CMD "cat /tmp/start_gui.log 2>/dev/null || true" 2>/dev/null || true
+    echo "  xvfb log:"
+    $SSH_CMD "cat /tmp/xvfb.log 2>/dev/null || true" 2>/dev/null || true
+    echo "  Process list:"
+    $SSH_CMD "ps aux | head -30" 2>/dev/null || true
+fi
+
+echo "Waiting for page to render..."
 sleep 15
 
+echo "Post-boot display state:"
+$SSH_CMD "DISPLAY=:0 xdotool search --onlyvisible --name . getwindowname 2>/dev/null || echo '(no visible windows)'" 2>/dev/null || true
+
 echo "Post-boot setup complete"