Security: Missing input validation in read_store function#5358
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The `read_store` function in `pycbc/frame/store.py` reads from an file using `HFile` but does not validate that `start_time` and `end_time consistent with the file's actual data ranges before performing array slicing. While there are some checks, the function could be more robust against malformed inputs. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Missing input validation in
read_storefunctionProblem
Severity:
Low| File:pycbc/frame/store.py:L56The
read_storefunction inpycbc/frame/store.pyreads from an file usingHFilebut does not validate thatstart_timeand `end_time consistent with the file's actual data ranges before performing array slicing. While there are some checks, the function could be more robust against malformed inputs.Solution
Add explicit bounds checking for
start_timeandend_timeparameters, and validate that the computedstartandendindices are within array bounds before slicing.Changes
pycbc/frame/store.py(modified)