Skip to content

Using geocenter time in PyGRB timeseries plots of all timeslides#5370

Draft
pannarale wants to merge 1 commit into
gwastro:masterfrom
pannarale:hiding-onsource
Draft

Using geocenter time in PyGRB timeseries plots of all timeslides#5370
pannarale wants to merge 1 commit into
gwastro:masterfrom
pannarale:hiding-onsource

Conversation

@pannarale

Copy link
Copy Markdown
Contributor

The executable that plots SNR timeseries of PyGRB analyses currently overlays slides using the detector time, when showing single IFO timeseries. This implies that:

  1. the onsource of a closed box is not correctly omitted for slid detector data, because geocenter start and end times are used to identify the onsource window;
  2. the horizontal axis values are mixing different meanings for different slides.

When the user wants to look at more than one slide at once, the correct thing to do is to use geocenter time. In other words, detector time is used only when a single slide is plotted, for a single detector.

With this switch, this PR address both issues listed above.

This is a: bug fix (item 1), improvement in results display (item 2)

This change affects: PyGRB

This change changes: result plotting

Testing performed

Here is a plot of all time slides for a specific GRB at L1
H1L1-PYGRB_PLOT_SNR_TIMESERIES_SINGLE_GRB1_L1_v287

Here is how it looks with these code changes
H1L1-PYGRB_PLOT_SNR_TIMESERIES_SINGLE_GRB1_L1_PR-under-v287

And here is a plot of a single time slide after the code changes, to ensure that the functionality is preserved
H1L1-PYGRB_PLOT_SNR_TIMESERIES_SINGLE_GRB1_L1_PR-under-v287-slide1

Additional notes

In the new version, the sliding is manifest (peaks are smeared rather than overlayed)

  • The author of this pull request confirms they will adhere to the code of conduct

@pannarale
pannarale requested a review from titodalcanton June 26, 2026 13:11
@pannarale pannarale self-assigned this Jun 26, 2026
@pannarale pannarale added bug BUG - FIX ASAP PyGRB PyGRB development v28_release_branch PRs to be cherry-picked into the v2.8 release branch v211_release_branch PRs to be cherry-picked into the v2.11 release branch labels Jun 26, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in PyGRB Development Jun 26, 2026
@pannarale
pannarale marked this pull request as draft June 26, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug BUG - FIX ASAP PyGRB PyGRB development v28_release_branch PRs to be cherry-picked into the v2.8 release branch v211_release_branch PRs to be cherry-picked into the v2.11 release branch work in progress

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant