Using geocenter time in PyGRB timeseries plots of all timeslides#5370
Draft
pannarale wants to merge 1 commit into
Draft
Using geocenter time in PyGRB timeseries plots of all timeslides#5370pannarale wants to merge 1 commit into
pannarale wants to merge 1 commit into
Conversation
pannarale
marked this pull request as draft
June 26, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The executable that plots SNR timeseries of PyGRB analyses currently overlays slides using the detector time, when showing single IFO timeseries. This implies that:
When the user wants to look at more than one slide at once, the correct thing to do is to use geocenter time. In other words, detector time is used only when a single slide is plotted, for a single detector.
With this switch, this PR address both issues listed above.
This is a: bug fix (item 1), improvement in results display (item 2)
This change affects: PyGRB
This change changes: result plotting
Testing performed
Here is a plot of all time slides for a specific GRB at L1

Here is how it looks with these code changes

And here is a plot of a single time slide after the code changes, to ensure that the functionality is preserved

Additional notes
In the new version, the sliding is manifest (peaks are smeared rather than overlayed)