Skip to content

Include GWT version, commit in JFR output#10312

Merged
niloc132 merged 6 commits into
gwtproject:mainfrom
niloc132:10269-jfr-vers
May 4, 2026
Merged

Include GWT version, commit in JFR output#10312
niloc132 merged 6 commits into
gwtproject:mainfrom
niloc132:10269-jfr-vers

Conversation

@niloc132
Copy link
Copy Markdown
Member

Enhances the "manual, opt-in analytics" by allowing users to upload JFR dumps of a build and detect which particular version or build resulted in the dump.

Deliberately omits command line args at this time - users can leave the default JVM events in place so these are detected or specify them manually. An automatic approach would need more code, able to remove details like paths and module names from the output.

Fixes #10269

@niloc132 niloc132 added this to the 2.14 milestone Apr 22, 2026
@niloc132 niloc132 requested a review from vegegoku April 22, 2026 20:00
Comment thread dev/core/src/com/google/gwt/dev/About.java Outdated
Co-authored-by: Zbynek Konecny <zbynek1729@gmail.com>
vegegoku
vegegoku previously approved these changes Apr 26, 2026
@vegegoku
Copy link
Copy Markdown
Member

There is a checkstyle issue.

@niloc132 niloc132 added the ready This PR has been reviewed by a maintainer and is ready for a CI run. label Apr 29, 2026
@zbynek
Copy link
Copy Markdown
Collaborator

zbynek commented Apr 29, 2026

assertTrue("Google Web Toolkit".equals(result));
needs updating too

@niloc132 niloc132 merged commit 48efe15 into gwtproject:main May 4, 2026
8 checks passed
niloc132 added a commit that referenced this pull request May 13, 2026
Enhances the "manual, opt-in analytics" by allowing users to upload JFR
dumps of a build and detect which particular version or build resulted
in the dump.

Deliberately omits command line args at this time - users can leave the
default JVM events in place so these are detected or specify them
manually. An automatic approach would need more code, able to remove
details like paths and module names from the output.

Fixes #10269
Backport #10312
Co-authored-by: Zbynek Konecny <zbynek1729@gmail.com>
Co-authored-by: Zbynek Konecny <zbynek@geogebra.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready This PR has been reviewed by a maintainer and is ready for a CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JFR profile should include version information, possibly other options

3 participants